Diffusion repository creation fails via toolsadmin
Open, NormalPublic

Description

An unexpected technical problem has occured while handing the requested URI /tools/id/coverage/repos/create. This is probably temporary and should be fixed soon. Please try again later.

If you report this error, please include the details below.

Request ID
    ef4ed5f882bd4e00933f3e5c3ff2e993
Legoktm created this task.Dec 5 2017, 7:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2017, 7:23 PM
bd808 added a comment.Dec 5 2017, 11:31 PM
2017-12-05T19:22:45Z [ef4ed5f882bd4e00933f3e5c3ff2e993] django.request ERROR: Internal Server Error: /tools/id/coverage/repos/create
Traceback (most recent call last):
  File "/srv/deployment/striker/venv/lib/python3.4/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/srv/deployment/striker/venv/lib/python3.4/site-packages/django/contrib/auth/decorators.py", line 22, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "./striker/tools/views/decorators.py", line 48, in decorated
    return f(*args, **kwargs)
  File "./striker/tools/views/repo.py", line 57, in create
    if form.is_valid():
  File "/srv/deployment/striker/venv/lib/python3.4/site-packages/django/forms/forms.py", line 184, in is_valid
    return self.is_bound and not self.errors
  File "/srv/deployment/striker/venv/lib/python3.4/site-packages/django/forms/forms.py", line 176, in errors
    self.full_clean()
  File "/srv/deployment/striker/venv/lib/python3.4/site-packages/django/forms/forms.py", line 392, in full_clean
    self._clean_fields()
  File "/srv/deployment/striker/venv/lib/python3.4/site-packages/django/forms/forms.py", line 410, in _clean_fields
    value = getattr(self, 'clean_%s' % name)()
  File "./striker/tools/forms.py", line 61, in clean_repo_name
    phab.get_repository(name)
  File "./striker/phabricator.py", line 165, in get_repository
    'order': 'name',
  File "./striker/phabricator.py", line 75, in post
    resp.get('result', None))
striker.phabricator.APIError: Constraint "name" is not a valid constraint for this query. (ERR-CONDUIT-CORE)

@20after4 did something change on the Phabricator side with this API?

mmodell added a subscriber: mmodell.Dec 7 2017, 4:59 AM

@Legoktm: I think a bunch of conduit APIs switched to using "query" instead of "name"...

Change 395924 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/striker@master] Update for diffusion.repository.search API change

https://gerrit.wikimedia.org/r/395924

chasemp triaged this task as Normal priority.Dec 12 2017, 3:24 PM

Change 395924 merged by jenkins-bot:
[labs/striker@master] Update for diffusion.repository.search API change

https://gerrit.wikimedia.org/r/395924

bd808 moved this task from Backlog to Ready on the Striker board.Dec 27 2017, 12:47 AM
SQL added a subscriber: SQL.Dec 27 2017, 12:50 AM

Change 401810 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/striker/deploy@master] Bump striker submodule and add ddl changes

https://gerrit.wikimedia.org/r/401810

Change 401810 merged by jenkins-bot:
[labs/striker/deploy@master] Bump striker submodule and add ddl changes

https://gerrit.wikimedia.org/r/401810

Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-01-03T22:31:18Z] <bd808@tin> Started deploy [striker/deploy@69f1b15]: Enhance membership request workflow and fix Diffusion repo creation (T168027, T182142)

Mentioned in SAL (#wikimedia-operations) [2018-01-03T22:31:48Z] <bd808@tin> Finished deploy [striker/deploy@69f1b15]: Enhance membership request workflow and fix Diffusion repo creation (T168027, T182142) (duration: 00m 31s)

bd808 added a comment.Jan 3 2018, 10:48 PM

Repo creation works again, but there is a bug of some sort that is breaking the display of newly created repos. Reloading the page fixes it, so it should be something I can track down and fix relatively easy.

Page after creation:

Reload fixes it:

bd808 moved this task from Ready to Doing on the Striker board.Jan 3 2018, 10:58 PM
1-Byte added a subscriber: 1-Byte.Jun 11 2018, 12:24 PM

It seems that the creation of new repositories failed again. A reload does not solve the issue: