Description

Regression from rMWbc3f4d1b1860: Absolutely position "legend" on grouped results (which is done for T174728).

With legend collapsed	With legend expanded

'Group results by page' option should be enabled.

Details

	Subject	Repo	Branch	Lines +/-
	Fix "Save current filter settings" menu and legend overlap	mediawiki/core	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T182156: RecentChanges legend overlaps actual RecentChanges
Mentioned Here: rMWbc3f4d1b1860: Absolutely position "legend" on grouped results
T174728: "Legend" retains some space if "Group results by change" is enabled

Event Timeline

Catrope created this task.Dec 7 2017, 12:48 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 7 2017, 12:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Etonkovidova renamed this task from Recent changes legend overlaps "save current filter settings" dialog to [wmf.11-regression] Recent changes legend overlaps "save current filter settings" dialog.Dec 7 2017, 1:07 AM

Etonkovidova updated the task description. (Show Details)

Change 395911 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] Fix "Save current filter settings" menu and legend overlap

https://gerrit.wikimedia.org/r/395911

gerritbot added a project: Patch-For-Review.Dec 7 2017, 2:12 AM

• Petar.petkovic claimed this task.Dec 7 2017, 2:13 AM

• Petar.petkovic edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.

• Petar.petkovic moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

• Petar.petkovic updated the task description. (Show Details)Dec 7 2017, 2:18 AM

I have also checked how "Saved filters" menu would behave if there were enough (or too many?) saved filters. As it currently stands, no overlap is happening.

saved-filters-menu-compared-to-legend.png (433×399 px, 14 KB)

List elements are duplicated in DevTools for the sake of faster testing, this is no indicator of duplicate filter names

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Dec 7 2017, 6:18 PM

Change 395911 merged by jenkins-bot:
[mediawiki/core@master] Fix "Save current filter settings" menu and legend overlap

https://gerrit.wikimedia.org/r/395911

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 7 2017, 7:00 PM

• Petar.petkovic removed a project: Patch-For-Review.Dec 7 2017, 8:44 PM

Checked the fix in betalabs.

Etonkovidova closed this task as Resolved.Dec 7 2017, 11:03 PM

• Petar.petkovic mentioned this in T182156: RecentChanges legend overlaps actual RecentChanges.Dec 8 2017, 6:27 PM

	F11273579: saved-filters-menu-compared-to-legend.png
	Dec 7 2017, 2:26 AM

	F11233301: Screenshot from 2017-12-06 16-44-45.png
	Dec 7 2017, 12:48 AM

	F11233319: Screenshot from 2017-12-06 16-44-55.png
	Dec 7 2017, 12:48 AM

[wmf.11-regression] Recent changes legend overlaps "save current filter settings" dialogClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[wmf.11-regression] Recent changes legend overlaps "save current filter settings" dialog
Closed, ResolvedPublic
Actions