Pasting HTML in NWE can't be undone via keyboard
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

Open a page for editing in NWE.
Copy from any article some HTML with a link.
Paste in NWE. As expected the content is transformed into wiki syntax.
Press Ctrl-Z.

Expected: The pasted content is removed again.
Actual: Nothing happens.

Undoing via toolbar works, undoing via keyboard for pastes without conversion works, too.
I tested in Firefox, both de.wikipedia.org and de.wikipedia.beta.wmflabs.org.

Details

	Subject	Repo	Branch	Lines +/-
	Only resolve wikitext promise when progress dialog has closed	mediawiki/extensions/VisualEditor	master	+10 -4

Customize query in gerrit

Related Objects

Mentioned In: T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing)

Event Timeline

Schnark created this task.Dec 8 2017, 11:03 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 8 2017, 11:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Looks like selection is getting restored correctly after async paste.

Change 397862 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Only resolve wikitext promise when progress dialog has closed

https://gerrit.wikimedia.org/r/397862

gerritbot added a project: Patch-For-Review.Dec 12 2017, 4:25 PM

• Deskana assigned this task to Esanders.Dec 12 2017, 7:58 PM

• Deskana triaged this task as Medium priority.

• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.

• Deskana set the point value for this task to 1.

Dvorapa subscribed.Dec 12 2017, 9:41 PM

Jdforrester-WMF moved this task from TR1: Releases to Current work on the VisualEditor board.Feb 21 2018, 6:17 PM

Jdforrester-WMF edited projects, added VisualEditor (Current work); removed VisualEditor.

Jdforrester-WMF moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Esanders mentioned this in T188839: When editing source, sometimes characters get put in strange places if you have too many characters on a line (due to space collapsing).Mar 5 2018, 5:11 PM

Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Apr 12 2018, 9:48 PM

Change 397862 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Only resolve wikitext promise when progress dialog has closed

https://gerrit.wikimedia.org/r/397862

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 17 2018, 4:54 PM

Jdforrester-WMF removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 17 2018, 5:00 PM

• Deskana closed this task as Resolved.Apr 18 2018, 11:19 AM

Pasting HTML in NWE can't be undone via keyboardClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Pasting HTML in NWE can't be undone via keyboard
Closed, ResolvedPublic1 Estimated Story Points
Actions