This happens when deleting on Special:DeleteBatch with a list of pages supplied with a file upload. Does not appear to happen when using the text area.
Encountered during testing for T180818: Convert DeleteBatch to use extension registration.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix message ambiguity and allow omitting pipe | mediawiki/extensions/DeleteBatch | master | +20 -8 |
Related Objects
Related Objects
- Mentioned In
- E809: Code Review Office Hours
- Mentioned Here
- T180818: Convert DeleteBatch to use extension registration
Event Timeline
Comment Actions
Yep, it seems to be the issue reported by @Zoranzoki21 on IRC a couple of days ago. Thanks for reporting!
Comment Actions
This happens because of the ambiguity of https://translatewiki.net/wiki/MediaWiki:Deletebatch-help/en which does make it look like the reason is optional, and by extension, the separating pipe. This is a case of not properly handling incorrect input: the extension should either allow omitting the pipe symbol or display an error that the format of the supplied file is not correct. Question is which of the approaches is the desirable one. I can whip up a patch if necessary.
Personally, I'm leaning towards to allow omitting the pipe, assuming it exists is the sole reason we're getting this error and the script runs fine despite the error.
Comment Actions
Omitting the pipe looks good to me. After all we can already delete pages w/o putting a reason.
Comment Actions
Change 403473 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/extensions/DeleteBatch@master] Fix message ambiguity and allow omitting pipe
Comment Actions
Change 403473 merged by jenkins-bot:
[mediawiki/extensions/DeleteBatch@master] Fix message ambiguity and allow omitting pipe