Wikidata mobileapps endpoints (summary/mobile-sections) throw 500
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 11 2017, 9:38 PM

Description

Per IRC locally when trying to access mobile-sections and summaries via wikidata.org a 500 is thrown. This does not appear to be enabled in production, so is not a big deal, but for completeness we should probably prevent these from 500ing even locally.

IRC conversation for prosperity:

jdlrobson> mdholloway: that said.. it shouldnt throw a 500 error :) http://0.0.0.0:6927/wikidata.org/v1/page/summary/Q1
1:34 PM "Cannot read property 'general' of undefined"
1:34 PM http://0.0.0.0:6927/wikidata.org/v1/page/mobile-sections/Q1
1:35 PM (we should disable for that host right?!)
1:35 PM mdholloway: should i raise a bug?
1:35 PM 
<mdholloway> Michael Holloway jdlrobson: please do!
1:35 PM thanks for catching that...
1:35 PM 
<jdlrobson> Jon Robson mdholloway: actually.. maybe it's fixed further up ? https://wikidata.org/api/rest_v1/page/mobile-sections/Q1
1:35 PM says that endoint is not available..
1:35 PM likewise: https://wikidata.org/api/rest_v1/page/summary

Details

	Subject	Repo	Branch	Lines +/-
	Correct API url for queries to Wikidata api	mediawiki/services/mobileapps	master	+4 -0

Customize query in gerrit

Related Objects

Duplicates Merged Here: T182629: Wikidata mobileapps endpoints (summary/mobile-sections) throw 500

Event Timeline

Jdlrobson created this task.Dec 11 2017, 9:38 PM

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptDec 11 2017, 9:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 397702 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/services/mobileapps@master] Correct API url for queries to Wikidata api

https://gerrit.wikimedia.org/r/397702

gerritbot added a project: Patch-For-Review.Dec 11 2017, 10:44 PM

Change 397702 abandoned by Jdlrobson:
Correct API url for queries to Wikidata api

https://gerrit.wikimedia.org/r/397702

Ignore me.
Looks like the domain I was using is wrong.
http://0.0.0.0:6927/www.wikidata.org/v1/page/summary/Q1 works fine. (204)

Not sure if we need to do any handling to check the domain is valid?
If not, feel free to decline.

We should probably be correctly handling the top-level wikidata.org domain.

The stuff under https://www.mediawiki.org/wiki/User:Phuedx_(WMF)/Reading/Web/Page_Preview_API#Responses_for_Wikidata_(from_T111231:_Page_previews_for_Wikidata) comes later and is still a todo, right?

@bearND I believe that's correct. Per a IRC convo with @Jdlrobson earlier Reading Web isn't using them, and I can't imagine the apps having a use for Wikidata summaries.

Yup, this bug is more about making the code readable and not 500 for when we do decide to do that :)

• Mholloway merged a task: T182629: Wikidata mobileapps endpoints (summary/mobile-sections) throw 500.Dec 13 2017, 1:44 PM

• Fjalapeno moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Mar 12 2018, 5:07 PM

• Fjalapeno edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

LGoto edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Product-Infrastructure-Team-Backlog-Deprecated (Kanban).Apr 18 2018, 8:22 PM

LGoto moved this task from Needs triage to Needs investigation on the Product-Infrastructure-Team-Backlog-Deprecated board.

@Jdlrobson @bearND can we clarify if work is needed here? And if so which team?

I think we can close this with the caveat that www.wikidata.org has to be used instead of just wikidata.org.
Not sure when the fix was made but curl -sI "http://0.0.0.0:6927/www.wikidata.org/v1/page/summary/Q1" returns status 200 with type: no-extract now.

Wikidata mobileapps endpoints (summary/mobile-sections) throw 500Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Wikidata mobileapps endpoints (summary/mobile-sections) throw 500
Closed, ResolvedPublic
Actions