CheckConstraints::newFromGlobalState is not covered by any tests, so when one of the classes instantiated in there gains a constructor parameter, nothing besides manual testing reminds us to update the instantiation. It should be split up into several functions, most of which can be tested on their own. (newFromGlobalState should probably do nothing more except passing WikibaseRepo::getDefaultInstance() and MediaWikiServices::getInstance() into those functions.)
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Split up and test CheckConstraints::newFromGlobalState | mediawiki/extensions/WikibaseQualityConstraints | master | +272 -84 |
Related Objects
Related Objects
- Mentioned In
- T190933: Reduce duplicated service instantiations in WBQC
- Mentioned Here
- T190933: Reduce duplicated service instantiations in WBQC
Event Timeline
Comment Actions
Change 406050 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Split up and test CheckConstraints::newFromGlobalState
Comment Actions
Change 406050 abandoned by Lucas Werkmeister (WMDE):
Split up and test CheckConstraints::newFromGlobalState
Reason:
no longer necessary – see especially T190933