Page MenuHomePhabricator
Create Task
Maniphest T190933

Reduce duplicated service instantiations in WBQC
Closed, ResolvedPublic
Actions

Description

WikibaseQualityConstraints has a ConstraintReportFactory class that instantiates several services; however, for more recent services, we seem to have stopped using it, instead copying+pasting service instantiations in several places. I don’t think this was a conscious decision, and I don’t see a reason why it would have to be this way. Let’s move some more services into ConstraintReportFactory.

Related: T183373: Refactor and split up CheckConstraints::newFromGlobalState (I think that task can actually be declined – as far as I can tell there’s no reason why CheckConstraints can’t use ConstraintReportFactory.)

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Add ResultsSource and auxiliary services to ConstraintReportFactorymediawiki/extensions/WikibaseQualityConstraintsmaster+169 -59
Use ConstraintReportFactory::getDefaultInstance()mediawiki/extensions/WikibaseQualityConstraintsmaster+1 -24
Rearrange ConstraintReportFactory membersmediawiki/extensions/WikibaseQualityConstraintsmaster+8 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 28 2018, 12:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2018, 12:31 PM
Lucas_Werkmeister_WMDE added a project: Technical-Debt.Mar 28 2018, 12:31 PM
Lydia_Pintscher moved this task from incoming to Features/bugs for later releases on the Wikibase-Quality-Constraints board.Apr 6 2018, 2:29 PM
WMDE-leszek added a project: Wikidata-Ministry-Of-Magic-Tech-Debt.Apr 13 2018, 10:47 AM
Lucas_Werkmeister_WMDE claimed this task.May 18 2018, 6:08 PM
Lucas_Werkmeister_WMDE added a project: Wikimedia-Hackathon-2018.
Lucas_Werkmeister_WMDE added a subscriber: Smalyshev.
• Quiddity moved this task from Backlog to Project on the Wikimedia-Hackathon-2018 board.May 19 2018, 2:50 PM
gerritbot subscribed.May 23 2018, 2:05 PM

Change 434703 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rearrange ConstraintReportFactory members

https://gerrit.wikimedia.org/r/434703

gerritbot added a project: Patch-For-Review.May 23 2018, 2:05 PM

Change 434704 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ConstraintReportFactory::getDefaultInstance()

https://gerrit.wikimedia.org/r/434704

gerritbot added a comment.May 23 2018, 2:05 PM

Change 434705 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ResultsSource and auxiliary services to ConstraintReportFactory

https://gerrit.wikimedia.org/r/434705

Lucas_Werkmeister_WMDE added a parent task: T194762: Add API to return violations in TTL (turtle) format.May 29 2018, 10:56 AM
Lucas_Werkmeister_WMDE added a project: Wikidata-Ministry-Of-Magic.

Adding to MoM board as part of T194762: Add API to return violations in TTL (turtle) format, which is already on the board.

Lucas_Werkmeister_WMDE moved this task from Tasks to Needs Review on the Wikidata-Ministry-Of-Magic board.May 29 2018, 10:56 AM
gerritbot added a comment.May 29 2018, 5:04 PM

Change 434703 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rearrange ConstraintReportFactory members

https://gerrit.wikimedia.org/r/434703

gerritbot added a comment.May 29 2018, 5:04 PM

Change 434704 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ConstraintReportFactory::getDefaultInstance()

https://gerrit.wikimedia.org/r/434704

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 29 2018, 6:00 PM
Ladsgroup moved this task from Needs Review to Done on the Wikidata-Ministry-Of-Magic board.May 31 2018, 9:34 AM
Ladsgroup moved this task from Done to In Progress on the Wikidata-Ministry-Of-Magic board.May 31 2018, 9:40 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 5 2018, 11:37 AM
Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.Jun 5 2018, 1:07 PM
Addshore moved this task from Incoming to Peer Review on the Wikidata-Campsite board.Jun 5 2018, 1:08 PM
gerritbot added a comment.Jun 5 2018, 2:10 PM

Change 434705 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add ResultsSource and auxiliary services to ConstraintReportFactory

https://gerrit.wikimedia.org/r/434705

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 5 2018, 2:11 PM
gerritbot mentioned this in T183373: Refactor and split up CheckConstraints::newFromGlobalState.Jun 5 2018, 2:13 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 5 2018, 2:13 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite board.
Lucas_Werkmeister_WMDE moved this task from Needs Review to Done on the Wikidata-Ministry-Of-Magic board.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)); removed MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).Jun 5 2018, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits