Maniphest T194762

Add API to return violations in TTL (turtle) format
Closed, ResolvedPublic
Actions

Description

We should add API which will return RDF (probably TTL) data in the following format:

wds:Q43$66E13CA3-37CB-4B14-9F53-311D9C91D822 wikibase:hasViolationForConstraint wds:P17$a02094d5-46fc-bb86-81d1-21cfea688dfe .
wds:q43$43124bad-4210-425f-5a0f-56e86c922055 wikibase:hasViolationForConstraint wds:P17$f2713cbe-499d-36e8-0a3a-c275a356b659 .

etc. etc. for each constraint violation. The left side is the statement violating the constraint, the right side is the statement on property that defines the constraint.

So far the easiest way seems to be to add action API, e.g.: https://wikidata-constraints.wmflabs.org/index.php/Item:Q5?action=constraintsrdf

Details

	Subject	Repo	Branch	Lines +/-
	Export constraint check results to RDF	mediawiki/extensions/WikibaseQualityConstraints	master	+156 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T244043 suggestions and possible decisions from the 2020 report on Property constraints
Open	None	T192565 Find constraint violations
Resolved	Smalyshev	T172380 Query constraint violations with WDQS
Resolved	Smalyshev	T192567 Expose constraint violations to WDQS
Resolved	Lucas_Werkmeister_WMDE	T194762 Add API to return violations in TTL (turtle) format
Resolved	Lucas_Werkmeister_WMDE	T190933 Reduce duplicated service instantiations in WBQC

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as Medium priority.May 15 2018, 2:07 PM

Lucas_Werkmeister_WMDE created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2018, 2:07 PM

• Rfarrand moved this task from Backlog to Project on the Wikimedia-Hackathon-2018 board.May 17 2018, 12:24 PM

Smalyshev added a project: User-Smalyshev.May 18 2018, 10:38 AM

Smalyshev subscribed.

Smalyshev moved this task from Backlog to Doing on the User-Smalyshev board.May 18 2018, 12:35 PM

Smalyshev claimed this task.May 18 2018, 4:30 PM

Smalyshev updated the task description. (Show Details)

Tricky part here may be that wbcheckconstraints is an API module, and make it return TTL may be non-trivial. We could of course wrap it inside JSON but that looks just wrong. Maybe we should use something like ?action=rdfConstraints instead?

Smalyshev updated the task description. (Show Details)May 19 2018, 12:24 PM

Smalyshev renamed this task from Add wbcheckconstraints parameter to return violations in TTL (turtle) format to Add API to return violations in TTL (turtle) format.May 19 2018, 12:27 PM

Smalyshev updated the task description. (Show Details)

Question: should we have different predicates for different types of violations, like mandatory, warning, etc.?

No, that can be inferred from the constraint statement itself (whether it has a “constraint status: mandatory constraint” or not).

Change 433964 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseQualityConstraints@master] [WIP] [DNM] Export constraint check results to RDF

https://gerrit.wikimedia.org/r/433964

gerritbot added a project: Patch-For-Review.May 19 2018, 4:02 PM

Lucas_Werkmeister_WMDE added a subtask: T190933: Reduce duplicated service instantiations in WBQC.May 29 2018, 10:56 AM

Lucas_Werkmeister_WMDE mentioned this in T190933: Reduce duplicated service instantiations in WBQC.

Lucas_Werkmeister_WMDE claimed this task.May 29 2018, 11:00 AM

Lucas_Werkmeister_WMDE moved this task from Tasks to In Progress on the Wikidata-Ministry-Of-Magic board.

Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.May 29 2018, 11:30 AM

Smalyshev moved this task from Doing to Next on the User-Smalyshev board.May 29 2018, 7:49 PM

The patch has DNM and WIP in it. Is it should stay in "needs review" column of MOM board?

I think the patch is a lot less WIP now – it still has one TODO as far as I recall (select output format), but apart from that I think it could be ready. Good enough to review at least, IMHO, and see what others think.

Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.Jun 5 2018, 1:08 PM

Addshore moved this task from Incoming to Peer Review on the Wikidata-Campsite board.Jun 5 2018, 1:08 PM

Lucas_Werkmeister_WMDE closed subtask T190933: Reduce duplicated service instantiations in WBQC as Resolved.Jun 5 2018, 2:14 PM

I'll update it soon, just didn't have time to look into it yet.

• Jonas moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite board.Jun 6 2018, 8:40 AM

Change 433964 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Export constraint check results to RDF

https://gerrit.wikimedia.org/r/433964

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 6 2018, 9:00 AM

This is very cool to find existing constraint violations! A great next step would be a service to test if a not yet existing statement would raise any violations! Is there a ticket for the constraint API to test not yet existing statements?

@Marsupium: yes, that’s T194194: Add possibility to check constraints on unsaved statements.