Use ar_parent_id on undeletion
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lahwaacz
	Dec 20 2017, 2:57 PM

Description

When a page is deleted, the revision.rev_parent_id field is saved as archive.ar_parent_id for all revisions when they are moved from revision into archive. But when a page is undeleted, each rev_parent_id is set to 0 regardless of the ar_parent_id value so there is loss of information.

There was T30553 about the problem but it seems that only half of it actually happened?!

Edit: Although I still don't see any code which would explicitly handle ar_parent_id when undeleting, it seems to be a problem of the API only, see the comment below.

Related Objects

Mentioned In: T38976: Diffs: Incorrect number of bytes added or removed because rev_parent_id is set to wrong revision
T193690: RFC: How should we fix the undeletion system?
T193211: Prevent broken parent revisions
T185167: Add a "Reset parent IDs" checkbox to the undelete interface
T186280: Create maintenance script to fix "broken" parent IDs
Mentioned Here: rMW745823287498: [MCR] Use RevisionStore::getArchiveQueryInfo in PageArchive
T185167: Add a "Reset parent IDs" checkbox to the undelete interface
T30553: set ar_parent_id on deletion

Event Timeline

Lahwaacz created this task.Dec 20 2017, 2:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2017, 2:57 PM

Lahwaacz updated the task description. (Show Details)Dec 20 2017, 2:58 PM

Actually, what used to happen is that the rev_parent_id was automatically determined based on comparison of the rev_id values, which usually produced a nonzero value. Now the problem seems to be partially solved, but see T185167 for adding something to the undelete interface to mimic the old behavior.

Huh, it seems that the Special:Undelete page sets rev_parent_id correctly somehow, but the API:Undelete module always sets it to 0.

Lahwaacz added a project: MediaWiki-Action-API.Jan 21 2018, 10:59 AM

Lahwaacz updated the task description. (Show Details)

Lahwaacz updated the task description. (Show Details)Jan 21 2018, 12:39 PM

I just tested this on the development master branch and the rev_parent_id was preserved correctly across undeletion both via the web UI and the action API. Further, since both the web UI and the action API perform the undeletion by calling PageArchive::undelete(), it seems unlikely that one would have different behavior than the other.

While I don't see any changes that would have fixed this between the currently-deployed 1.31.0-wmf.17 branch and the development master, the current development master is scheduled to be deployed to be deployed to WMF wikis with 1.31.0-wmf.20, see https://www.mediawiki.org/wiki/MediaWiki_1.31/Roadmap for the schedule.

My best guess is that this was fixed with rMW745823287498: [MCR] Use RevisionStore::getArchiveQueryInfo in PageArchive, which was deployed to WMF wikis with 1.31.0-wmf.16.

T185167: Add a "Reset parent IDs" checkbox to the undelete interface is indeed related, in that that bug is complaining about the fact that this bug was fixed.

Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 22 2018, 3:16 PM

Anomie removed a project: MediaWiki-Action-API.Jan 22 2018, 3:36 PM

Further, since both the web UI and the action API perform the undeletion by calling PageArchive::undelete(), it seems unlikely that one would have different behavior than the other.

Well, that's exactly what happens in MW 1.30.0... Let's hope you're right about the fix.

GTrang mentioned this in T186280: Create maintenance script to fix "broken" parent IDs.Feb 1 2018, 11:40 PM

GTrang mentioned this in T185167: Add a "Reset parent IDs" checkbox to the undelete interface.Feb 4 2018, 3:39 AM

Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.Feb 12 2018, 1:28 PM

GTrang mentioned this in T193211: Prevent broken parent revisions.Apr 26 2018, 11:22 PM

GTrang mentioned this in T193690: RFC: How should we fix the undeletion system?.May 2 2018, 11:44 PM

daniel mentioned this in T38976: Diffs: Incorrect number of bytes added or removed because rev_parent_id is set to wrong revision.Sep 16 2018, 8:33 AM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM