In the mediawiki/extensions/EventBus repository, there's a class called EventBusHooks, that has a function, onArticleRevisionVisibilitySet, which likely unintentionally creates new global functions.
In PHP, creating a function inside a class static function actually creates a global function (unlike JavaScript). https://3v4l.org/7tNtb
This should be switched to having private static helper functions instead of creating new global functions.
I'll mentor this for Google-Code-in-2017
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix unintentionally created global functions in EventBusHooks | mediawiki/extensions/EventBus | master | +52 -44 |
By the way, I noticed that function onBlockIpComplete unintentionally creates new global function too. This will be also fixed in my patch.
Change 400571 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[mediawiki/extensions/EventBus@master] Fix unintentionally created global functions in EventBusHooks
Change 400571 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Fix unintentionally created global functions in EventBusHooks