Page MenuHomePhabricator
Create Task
Maniphest T183756

Detect global functions definied inside static functions
Closed, ResolvedPublic
Actions

Description

On T183730 there was a global function found created inside a static function.

Codesniffer should at least detect these function with it's PrefixedGlobalFunctionsSniff.

Maybe it is better to detect and forbid them, even there are named wf*?

Details

SubjectRepoBranchLines +/-
Prohibit nested functionsmediawiki/tools/codesniffermaster+172 -88
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Dec 28 2017, 9:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 28 2017, 9:45 PM
Legoktm moved this task from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.Feb 14 2018, 7:19 PM
gerritbot subscribed.Mar 18 2018, 7:50 AM

Change 420231 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/tools/codesniffer@master] Prohibit nested functions

https://gerrit.wikimedia.org/r/420231

gerritbot added a project: Patch-For-Review.Mar 18 2018, 7:50 AM
MaxSem moved this task from Accepted rule changes to In progress on the MediaWiki-Codesniffer board.Mar 18 2018, 7:52 AM
gerritbot added a comment.Jul 26 2018, 3:45 AM

Change 420231 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Prohibit nested functions

https://gerrit.wikimedia.org/r/420231

Legoktm closed this task as Resolved.Jul 26 2018, 3:45 AM
Legoktm assigned this task to MaxSem.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits