Page MenuHomePhabricator

Keyboard accessibility help dialog
Closed, ResolvedPublic

Description

When I enter '?' on https://query.wikidata.org I should get a dialog showing the list of keyboard shortcuts.

Ctrl/Command+Enter: Run query
Esc: Leave current input field/textarea
?: Toggle Help menu
i: Focus on query textarea
r: Jump to query result
f: Focus on "Fliter" button in Query Helper
s: Focus on "Show" button in Query Helper
m: Click "Limit" button in Query Helper
e: Show examples
l: Show language menu

Mock:

image.png (312×760 px, 23 KB)

Notice existing shortcut should get different key assigned.

Event Timeline

Jonas triaged this task as Medium priority.Jan 2 2018, 3:46 PM
Jonas created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I fail to parse "Notice existing shortcut should get different key assigned." - care to elaborate? :)

I fail to parse "Notice existing shortcut should get different key assigned." - care to elaborate? :)

? is already bound to toggle the “Help” menu, so that function needs a different key. h seems to be free :)

Change 401729 had a related patch set uploaded (by Eflyjason; owner: Eflyjason):
[wikidata/query/gui@master] Keyboard accessibility help dialog

https://gerrit.wikimedia.org/r/401729

Jonas lowered the priority of this task from Medium to Low.Jan 4 2018, 5:43 PM
Jonas moved this task from Backlog to Done on the Wikidata Query UI board.

Change 401729 merged by jenkins-bot:
[wikidata/query/gui@master] Keyboard accessibility help dialog

https://gerrit.wikimedia.org/r/401729

This "?" would be a keyboard shortcut, not something I type in some box or so?

@Lucas_Werkmeister_WMDE:

is already bound to toggle the “Help” menu, so that function needs a different key. h seems to be free :)

Which help menu? Query Service one or the browsers?

This "?" would be a keyboard shortcut, not something I type in some box or so?

Yes, but by default the focus is inside the query editor. The ? becomes a keyboard shortcut when the query editor loses focus, e. g. by pressing Esc or by clicking somewhere else.

Which help menu?

Query Service (between Examples and Tools).