Page MenuHomePhabricator

Keyboard accessibility for Query.Wikidata.org not working as intended on mobile devices
Closed, ResolvedPublic

Description

Currently, when we type shortcuts like e or f in textarea on mobile devices, the corresponding action will be triggered. However, these action shouldn't be triggered when user is focused on textarea. The problem lies in

if ( $( document.activeElement ).is( 'textarea, input' ) ) {
	if ( e.key === 'Escape' ) {
		$( document.activeElement ).blur();
	}
	return;
}

Event Timeline

Change 402814 had a related patch set uploaded (by Eflyjason; owner: Eflyjason):
[wikidata/query/gui@master] Fix document.activeElement when focusing on textarea on mobile devices

https://gerrit.wikimedia.org/r/402814

Change 402814 merged by jenkins-bot:
[wikidata/query/gui@master] Fix document.activeElement when focusing on textarea on mobile devices

https://gerrit.wikimedia.org/r/402814

Jonas moved this task from Backlog to Done on the Wikidata Query UI board.
238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
This comment was removed by Vgutierrez.
Vgutierrez changed the visibility from "Custom Policy" to "Public (No Login Required)".
Vgutierrez removed subscribers: Vgutierrez, 238482n375.
Vgutierrez added a subscriber: Vgutierrez.