Page MenuHomePhabricator
Create Task
Maniphest T185266

INVALID_CHARACTER_ERR (5): the string contains invalid characters
Closed, ResolvedPublic
Actions

Description

From http://localhost:8000/wikimediafoundation.org/v3/page/html/L11_ExtraInfo_0902_Y%2Fen%2FUS/67456

What's happening is that there's a registered extension tag <html> on that wiki that's returning garbage. domino parses the returned html just fine but when we get to unpacking the dom, we now use migrating nodes between doms which barfs when trying to adopt the nodes.

Details

SubjectRepoBranchLines +/-
Prevent crashing on foundationwiki pagesmediawiki/services/parsoidmaster+25 -4
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Jan 18 2018, 10:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2018, 10:39 PM
Arlolra triaged this task as Low priority.Jan 18 2018, 10:39 PM
Arlolra added a comment.Jan 18 2018, 11:23 PM

Another case where the lack of extension content sanitization is biting us.

Arlolra claimed this task.Mar 2 2018, 12:54 AM
gerritbot subscribed.Mar 2 2018, 1:42 AM

Change 415791 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Prevent crashing on foundationwiki pages

https://gerrit.wikimedia.org/r/415791

gerritbot added a project: Patch-For-Review.Mar 2 2018, 1:42 AM
Arlolra added a comment.Apr 6 2018, 5:18 PM

See T179082 for a proper solution.

Arlolra mentioned this in T179082: Use one ownerDocument for the entire parse.Apr 6 2018, 5:19 PM
gerritbot added a comment.Apr 6 2018, 5:27 PM

Change 415791 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Prevent crashing on foundationwiki pages

https://gerrit.wikimedia.org/r/415791

Arlolra closed this task as Resolved.Apr 6 2018, 5:32 PM
Stashbot mentioned this in T191281: VisualEditor breaks galleries with <br /> in image captions.Apr 9 2018, 8:48 PM
Stashbot mentioned this in T187386: Cannot read property 'unshift' of undefined.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-04-09T20:48:08Z] <arlolra> Updated Parsoid to edeeb60 (T191281, T187386, T185266)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits