Problem with User.php if no cookies present
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Seppl2013
	Dec 7 2008, 2:53 AM

Description

When trying to login into a wiki immediately after clearing all cookies in a browser the
access to the $_SESSION variable in line 2111 will fail, since it is not set.
Here is the fix:

		if (isset($_SESSION)) 
			$_SESSION = $session + $_SESSION;
		else
		  $_SESSION = $session;

Version: 1.13.x
Severity: minor

Details

Reference: bz16579

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:30 PM

• bzimport added a project: MediaWiki-User-login-and-signup.

• bzimport set Reference to bz16579.

• bzimport added a subscriber: Unknown Object (MLST).

Seppl2013 created this task.Dec 7 2008, 2:53 AM

Done in r45374

r45374 doesn't look like it'll have any affect whatsoever -- !is_null() and isset() will be returning the same result, so there'll be no change in behavior. If it was wrong before, it's still wrong.

is_null throws notices if the variable is not defined.

So the state of the bug was "already fixed" before r45374, and r45374 was simply a cleanup for a notice warning in the already-existing fix?

Meno25 unsubscribed.Nov 23 2018, 7:47 AM

In T18579#218719, @brion wrote:

So the state of the bug was "already fixed" before r45374, and r45374 was simply a cleanup for a notice warning in the already-existing fix?

Reflecting reality. This part of User/session handling has already been overhauled in 1.27 anyways.

Problem with User.php if no cookies presentClosed, ResolvedPublicActions

Description

Details

Event Timeline

Problem with User.php if no cookies present
Closed, ResolvedPublic
Actions