| Addshore | |
| Feb 6 2018, 3:50 PM |
| F13122124: image.png | |
| Feb 6 2018, 3:50 PM |
Importing revisions with the FileImporter results in incorrect revision size diff values
This can be seen at https://test.wikimedia.beta.wmflabs.org/w/index.php?title=File:2013_Porsche_911_Carrera_4S_(991)_(9626546987).jpg&action=history
Note Are we calling the revisions in the wrong order? Is there something that we should be calling at the import that we are not? Look at the todos!
https://github.com/wikimedia/mediawiki-extensions-FileImporter/blob/master/src/Services/Importer.php#L204
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Import text revisions in the order of oldest to newest | mediawiki/extensions/FileImporter | master | +3 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Lea_WMDE | T187531 Small beta Prerequisites | |||
| Resolved | Andrew-WMDE | T186609 Importing revisions with the FileImporter results in incorrect revision size diff values |
So it appears that when we import the revisions we don't link revisions with their parent revision. Therefore, in the database the entry 'rev_parent_id' is 0 for all the revisions that are being imported (not the revisions we create additionally). As a result, when the history class attempts to calculate the difference in bytes it takes each imported revision and compares it to the initial revision of the page. This leads to the byte difference being the same as revision's actual size.
https://www.mediawiki.org/wiki/Manual:Revision_table#rev_parent_id
Change 418944 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] Import text revisions in the order of oldest to newest
Import the revisions in the order of oldest to newest so that during the import process the proper rev_parent_id can be determined for each revision in:
https://github.com/wikimedia/mediawiki/blob/efcd9f92e82a823b92e64486419cdfed6d34e40c/includes/import/ImportableOldRevisionImporter.php#L97
Change 418944 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Import text revisions in the order of oldest to newest