Page MenuHomePhabricator
Create Task
Maniphest T186788

[Bug] Special:SetSiteLink shows the form twice after an error
Closed, ResolvedPublic
Actions

Description

Special:SetSiteLink contains the form twice when showing an error message after an error:

SetSiteLink.png (1×546 px, 28 KB)

Details

SubjectRepoBranchLines +/-
Add missing return to SpecialModifyEntitymediawiki/extensions/Wikibasemaster+3 -5
Customize query in gerrit

Event Timeline

Fomafix created this task.Feb 8 2018, 12:56 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 8 2018, 12:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Feb 13 2018, 5:26 PM

Change 410213 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Add missing return to SpecialModifyEntity

https://gerrit.wikimedia.org/r/410213

gerritbot added a project: Patch-For-Review.Feb 13 2018, 5:26 PM
thiemowmde claimed this task.Feb 13 2018, 5:29 PM
thiemowmde triaged this task as Medium priority.
thiemowmde moved this task from incoming to ready to go on the Wikidata board.
thiemowmde added a project: good first task.
thiemowmde added subscribers: thiemowmde, daniel.

I was able to reproduce the error quite easily by temporarily adding return Status::newFatal( 'dummy' ); to SpecialWikibaseRepoPage::saveEntity, and simulating an error that way. The same issue with the duplicate form then appears in all special pages that are based on the same abstract class: Special:SetLabel, description, aliases, and sitelinks.

Kizule moved this task from Backlog to Doing on the good first task board.May 17 2018, 4:34 PM
gerritbot added a comment.May 18 2018, 12:44 AM

Change 410213 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add missing return to SpecialModifyEntity

https://gerrit.wikimedia.org/r/410213

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 18 2018, 1:00 AM
Addshore closed this task as Resolved.Sep 18 2018, 12:07 PM
Addshore subscribed.

It looks like this is fixed

image.png (693×1 px, 78 KB)

Fomafix removed a project: Patch-For-Review.Oct 20 2018, 8:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits