Page MenuHomePhabricator
Create Task
Maniphest T186844

Media viewer discarding sub / sup markup in captions
Closed, ResolvedPublic
Actions

Description

When a captioned image is displayed with Media Viewer, styling of the caption is discarded for multiple types of markup. This can change the meaning of the caption, for example when supscript and superscript characters are appended to words.

Details

SubjectRepoBranchLines +/-
MMV: Allow <sub> and <sup> in captionsmediawiki/extensions/MultimediaViewermaster+3 -3
Customize query in gerrit

Event Timeline

Xaosflux created this task.Feb 9 2018, 1:57 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 9 2018, 1:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Xaosflux added a comment.Feb 9 2018, 1:58 AM

Steps to reproduce:

  1. Use session configured to use mediaviewer
  2. Go to https://en.wikipedia.org/w/index.php?title=User:Xaosflux/sandbox52&oldid=824719956
  3. Click the image
Xaosflux added a comment.Feb 9 2018, 1:59 AM

Identified on enwiki VPT (https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=824720094#Media_viewer_and_subscript/superscript)

Xaosflux renamed this task from Media viewer discards markup in captions to Media viewer discards many types of markup in captions.Feb 9 2018, 3:43 AM
Xaosflux updated the task description. (Show Details)
TheDJ subscribed.Feb 9 2018, 9:00 AM
gerritbot subscribed.Feb 9 2018, 9:35 AM

Change 409302 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/MultimediaViewer@master] MMV: Allow <sub> and <sup> in captions

https://gerrit.wikimedia.org/r/409302

gerritbot added a project: Patch-For-Review.Feb 9 2018, 9:35 AM
TheDJ added a comment.Feb 9 2018, 9:45 AM

These elements are intentionally filtered, but i see no reason not to add sub and sup to the whitelisted elements.

Xaosflux renamed this task from Media viewer discards many types of markup in captions to Media viewer discarding sub / sup markup in captions.Feb 9 2018, 12:47 PM
Xaosflux triaged this task as Low priority.
Xaosflux added a comment.Feb 9 2018, 12:50 PM

@TheDJ I'll re-titled this request for just that action so it can be closable, can update https://www.mediawiki.org/wiki/Help:Extension:Media_Viewer - question: I noticed "span" is in the list at mmv.HtmlUtils.js - will that drag any inline "style=" markup with it if attached to the span?

gerritbot added a comment.Feb 9 2018, 3:43 PM

Change 409302 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] MMV: Allow <sub> and <sup> in captions

https://gerrit.wikimedia.org/r/409302

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 9 2018, 4:00 PM
• Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.Feb 9 2018, 9:02 PM
TheDJ closed this task as Resolved.Feb 11 2018, 12:52 PM
TheDJ claimed this task.
TheDJ removed a project: Patch-For-Review.
In T186844#3958093, @Xaosflux wrote:

I noticed "span" is in the list at mmv.HtmlUtils.js - will that drag any inline "style=" markup with it if attached to the span?

I guess so.

• Phabricator_maintenance moved this task from Incoming to 2017-18 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL