Create a file move limit based on file + revision size, and enforce it
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The following limit checks should be added to the FileImporter. For both checks we want to implement a configurable value that defaults to the value given and a hard coded upper limit.

sum of number of file and text revisions (100 revisions)
sum of size of file and text revisions in bytes (250 MB)
maximum filesize / uploadsize (as enforced by MediaWiki uploading)

Details

	Subject	Repo	Branch	Lines +/-
	Change max sum of revisions and aggregated bytes	mediawiki/extensions/FileImporter	master	+134 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lea_WMDE	T187531 Small beta Prerequisites
		Resolved		• aniansson	T187214 Create a file move limit based on file + revision size, and enforce it

Event Timeline

Lea_WMDE created this task.Feb 13 2018, 4:48 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptFeb 13 2018, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tobi_WMDE_SW renamed this task from Create a file move limit based on rile + revision side, and enforce it to Create a file move limit based on file + revision side, and enforce it.Feb 13 2018, 4:48 PM

Tobi_WMDE_SW renamed this task from Create a file move limit based on file + revision side, and enforce it to Create a file move limit based on file + revision size, and enforce it.

Tobi_WMDE_SW updated the task description. (Show Details)Feb 13 2018, 4:55 PM

Tobi_WMDE_SW set the point value for this task to 3.

Tobi_WMDE_SW moved this task from Tickets in sprint to Tickets ready for pickup on the Move-Files-To-Commons board.

Addshore updated the task description. (Show Details)Feb 13 2018, 4:55 PM

Addshore updated the task description. (Show Details)

Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2018-02-20.Feb 20 2018, 4:36 PM

Tobi_WMDE_SW moved this task from Proposed to Sprint backlog on the WMDE-QWERTY-Sprint-2018-02-20 board.

Addshore moved this task from Sprint backlog to Doing on the WMDE-QWERTY-Sprint-2018-02-20 board.Feb 21 2018, 3:03 PM

Addshore moved this task from Doing to Sprint backlog on the WMDE-QWERTY-Sprint-2018-02-20 board.

Change 413367 had a related patch set uploaded (by Ebba Aniansson; owner: Ebba Aniansson):
[mediawiki/extensions/FileImporter@master] [WIP] Changed the max sum of file and text revisions to 100, and max aggregated sum of bytes to 250mb

https://gerrit.wikimedia.org/r/413367

gerritbot added a project: Patch-For-Review.Feb 22 2018, 2:15 PM

• aniansson mentioned this in rEFLI721422f0a383: [WIP] Changed the max sum of file and text revisions to 100, and max aggregated….Feb 22 2018, 2:17 PM

WMDE-Fisch added a project: WMDE-TechWish.Feb 23 2018, 12:28 PM

WMDE-Fisch updated the task description. (Show Details)

WMDE-Fisch moved this task from Proposed to Done on the WMDE-TechWish board.

WMDE-Fisch moved this task from Done to Currently in sprint on the WMDE-TechWish board.

• aniansson claimed this task.Feb 23 2018, 12:46 PM

• aniansson moved this task from Sprint backlog to Doing on the WMDE-QWERTY-Sprint-2018-02-20 board.

• aniansson mentioned this in rEFLI1820896dcf20: Change max sum of revisions and aggregated bytes.Feb 23 2018, 2:08 PM

Lea_WMDE moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.Feb 26 2018, 2:16 PM

Lea_WMDE added a parent task: T187531: Small beta Prerequisites.Feb 26 2018, 3:03 PM