Page MenuHomePhabricator

[Bug] The sort articles popover is appearing in the center of iPad screens
Closed, ResolvedPublic

Description

Why are we doing this?

On iPhone we are using an action sheet when users tap on the 'sort' button. On iPad we need to utilize a popover. In the current implementation, this popover is appearing in the center of the All articles view, however it should be anchored to the Sort button.

Proposed solution

Anchor the popover to the Sort button on iPads

Current implementationProposed solution
Simulator Screen Shot - iPad (5th generation) - 2018-02-15 at 11.20.27.png (1×2 px, 962 KB)
iPad.png (768×1 px, 198 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JMinor triaged this task as Medium priority.Feb 26 2018, 6:19 PM
JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

@NHarateh_WMF, popover looks good!
It looks like just the icon on the tab bar for Saved is toggle to unselected when the popover is active though.

Simulator Screen Shot - iPad Pro (9.7-inch) - 2018-03-01 at 13.25.27.png (1×2 px, 761 KB)

@NHarateh_WMF

Hey I chatted with @cmadeo and it's fine if it would fight less with the way the toolbar operates by default to ensure the "Saved" icon text gets grayed out rather than the icon remaining blue.