Page MenuHomePhabricator
Create Task
Maniphest T187832

Trying to update the list of publishers resulted in me doing vandalism instead
Closed, ResolvedPublic
Actions

Description

Please see https://www.mediawiki.org/wiki/Topic:U800s096icpy8fcy

Details

SubjectRepoBranchLines +/-
Fix error handling and abuse filter integration during editmediawiki/extensions/Newslettermaster+77 -68
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Feb 20 2018, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2018, 9:47 PM
QuimGil subscribed.Feb 20 2018, 9:59 PM

This looks like the counterpart of T175497: Fields of newsletter not being updated in the newsletter info page (your own update triggered something that finally unblocked the update that got stuck somewhere for months).

Quiddity mentioned this in T188139: Updating the list of Newsletter publishers is not recorded in page history.Feb 23 2018, 9:06 PM
gerritbot subscribed.Jul 18 2018, 7:58 PM

Change 446642 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

https://gerrit.wikimedia.org/r/446642

gerritbot added a project: Patch-For-Review.Jul 18 2018, 7:58 PM
gerritbot added a comment.Dec 3 2019, 10:18 PM

Change 446642 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

https://gerrit.wikimedia.org/r/446642

gerritbot added a comment.Aug 13 2022, 6:00 PM

Change 446642 abandoned by Pppery:

[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

Reason:

Abandoning old unreviewed patches of mine that aren't particularly important.

https://gerrit.wikimedia.org/r/446642

gerritbot added a comment.Mar 25 2023, 9:23 PM

Change 446642 restored by Pppery:

[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

https://gerrit.wikimedia.org/r/446642

Pppery claimed this task.Mar 25 2023, 9:27 PM
gerritbot added a comment.Jun 24 2023, 5:58 PM

Change 446642 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Fix error handling and abuse filter integration during edit

https://gerrit.wikimedia.org/r/446642

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 24 2023, 6:00 PM
Pppery closed this task as Resolved.Jun 24 2023, 6:22 PM
In T187832#3987502, @QuimGil wrote:

This looks like the counterpart of T175497: Fields of newsletter not being updated in the newsletter info page (your own update triggered something that finally unblocked the update that got stuck somewhere for months).

This was correct - the bug was that any updates by publishers didn't get saved and any updates by admins did and unblocked them. I've fixed the underlying bug and null edited all newsletters on MediaWiki.org to clear any stuck updates.

Any stuck updates that exist on other wikis will get applied with the next edit, but there's no way to retroactively fix that.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL