New precache endpoint isn't reporting its metrics correctly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	awight
	Feb 21 2018, 5:19 PM

Description

Scores going through the /precache endpoint aren't showing up under "Precaching scores returned". Needs a metrics tweak.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Pchelolo	T158437 Change ORES rules to send all events to new "/precache" endpoint
		Resolved		awight	T187914 New precache endpoint isn't reporting its metrics correctly

Event Timeline

awight triaged this task as Medium priority.Feb 21 2018, 5:19 PM

awight created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2018, 5:19 PM

scoring_system.py, line 48:

if not request.precache:
    self.metrics_collector.scores_request(request, duration)
else:
    self.metrics_collector.precache_request(request, duration)

https://github.com/wiki-ai/ores/pull/246

awight claimed this task.Feb 21 2018, 5:27 PM

awight moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.

awight mentioned this in rORES76816d95d22b: Mark new-style precache request for metrics purposes.Feb 21 2018, 5:46 PM

Mentioned in SAL (#wikimedia-operations) [2018-02-21T21:15:26Z] <awight@tin> Started deploy [ores/deploy@7bbf21f]: T187914 on the ores* cluster

Mentioned in SAL (#wikimedia-operations) [2018-02-21T21:28:28Z] <awight@tin> Finished deploy [ores/deploy@7bbf21f]: T187914 on the ores* cluster (duration: 13m 03s)

Mentioned in SAL (#wikimedia-operations) [2018-02-21T21:29:05Z] <awight@tin> Started deploy [ores/deploy@addba9c]: T187914 on the scb* cluster

Mentioned in SAL (#wikimedia-operations) [2018-02-21T21:39:07Z] <awight@tin> Finished deploy [ores/deploy@addba9c]: T187914 on the scb* cluster (duration: 10m 02s)

Liuxinyu970226 subscribed.Feb 22 2018, 9:47 AM

awight moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Feb 26 2018, 1:14 PM

awight mentioned this in Unknown Object (Phame Post).May 2 2018, 6:41 PM

awight mentioned this in Unknown Object (Phame Post).

awight mentioned this in Blog Post: Status Update (May 2, 2018).

awight closed this task as Resolved.May 2 2018, 6:48 PM

Liuxinyu970226 unsubscribed.May 3 2018, 2:31 PM