Page MenuHomePhabricator
Create Task
Maniphest T188898

VisualEditor converts reference list template to plain reference list on cs.wiki
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The {{Poznámky pod čarou}} template is a wrapper of <references group="P"/>

But VisualEditor changes it automatically to <references />, which breaks desired behavior

See 1, 2 and 3 for example

Details

SubjectRepoBranchLines +/-
Fix detection of template-generated ref listsmediawiki/extensions/Citewmf/1.31.0-wmf.23+79 -3
Fix detection of template-generated ref listsmediawiki/extensions/Citemaster+79 -3
Customize query in gerrit

Event Timeline

Dvorapa created this task.Mar 5 2018, 9:26 AM
Restricted Application added subscribers: Kizule, Aklapper. · View Herald TranscriptMar 5 2018, 9:26 AM
Dvorapa triaged this task as Unbreak Now! priority.Mar 5 2018, 9:27 AM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 5 2018, 9:27 AM
JAnD subscribed.Mar 5 2018, 12:23 PM
Esanders renamed this task from VisualEditor breaks underline notes (references group) automatically to VisualEditor converts reference list template to plain reference list on cs.wiki.Mar 5 2018, 12:28 PM
Esanders claimed this task.
Esanders edited projects, added VisualEditor-MediaWiki-References, VisualEditor (Current work); removed VisualEditor.
Esanders updated the task description. (Show Details)
gerritbot subscribed.Mar 5 2018, 4:09 PM

Change 416462 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Cite@master] Fix detection of template-generated ref lists

https://gerrit.wikimedia.org/r/416462

gerritbot added a project: Patch-For-Review.Mar 5 2018, 4:09 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Mar 5 2018, 4:11 PM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Mar 5 2018, 4:25 PM

Change 416462 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Fix detection of template-generated ref lists

https://gerrit.wikimedia.org/r/416462

gerritbot added a comment.Mar 5 2018, 4:26 PM

Change 416467 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/Cite@wmf/1.31.0-wmf.23] Fix detection of template-generated ref lists

https://gerrit.wikimedia.org/r/416467

gerritbot added a comment.Mar 5 2018, 7:33 PM

Change 416467 merged by jenkins-bot:
[mediawiki/extensions/Cite@wmf/1.31.0-wmf.23] Fix detection of template-generated ref lists

https://gerrit.wikimedia.org/r/416467

Jdforrester-WMF closed this task as Resolved.Mar 5 2018, 8:59 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.
Jdforrester-WMF subscribed.

This is now fixed and backported to production.

Liuxinyu970226 unsubscribed.Mar 6 2018, 2:07 AM
• Deskana set the point value for this task to 1.Mar 6 2018, 10:42 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Mar 6 2018, 3:01 PM
Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits