In T183938, visual diffs were disabled on section edits due to them rendering the entire page as having been deleted other than the section the user is editing. This is good since disabling it better than doing something obviously wrong. However, it is not indicated to the user why the diff is disabled. This should be done.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Esanders | T190845 Show visual diffs on source mode section edits | |||
| Resolved | • Esanders | T183938 Visual diff on a section edit shows every other section to have been deleted (but the edit saves correctly) | |||
| Declined | • Esanders | T190310 Indicate to user why visual diffs are disabled on section edit |
Event Timeline
Comment Actions
We could do an on-hover thing (bad for mobile), and/or an on-click thing (good for mobile, not as good for desktop), with a message like "Visual diffs are not supported when editing a section."
Comment Actions
I might actually able to get the section editing diffs working now that Parsoid adds section attributes, rendering this task redundant :)