Page MenuHomePhabricator

Rename Lua functions in old naming scheme
Closed, ResolvedPublic

Description

We have a few Lua functions that were introduced very early to our Lua interface, that clearly fall out of our usual (current) naming scheme.

Therefore I suggest to name the following functions as:

The old names should obviously be turned into aliases to the new names, so that this isn't a breaking change.

Related Objects

StatusAssignedTask
InvalidNone
Resolvedhoo

Event Timeline

hoo created this task.Mar 22 2018, 3:03 AM
hoo triaged this task as Normal priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2018, 3:03 AM

Change 422090 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Lua: Rename old mw.wikibase getters to new naming scheme

https://gerrit.wikimedia.org/r/422090

Change 422090 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Lua: Rename old mw.wikibase getters to new naming scheme

https://gerrit.wikimedia.org/r/422090

hoo moved this task from Blocked to Done on the Wikidata-Ministry-Of-Magic board.Mar 27 2018, 11:56 AM
hoo closed this task as Resolved.
hoo removed a project: Patch-For-Review.
hoo claimed this task.

Change 423352 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Update Lua type checks to new function names

https://gerrit.wikimedia.org/r/423352

Change 423352 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update Lua type checks to new function names

https://gerrit.wikimedia.org/r/423352