Maniphest T190382

Rename Lua functions in old naming scheme
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hoo
	Mar 22 2018, 3:03 AM

Description

We have a few Lua functions that were introduced very early to our Lua interface, that clearly fall out of our usual (current) naming scheme.

Therefore I suggest to name the following functions as:

[[https://www.mediawiki.org/wiki/Extension:Wikibase_Client/Lua#mw.wikibase.label|mw.wikibase.label]] -> mw.wikibase.getLabel
[[https://www.mediawiki.org/wiki/Extension:Wikibase_Client/Lua#mw.wikibase.sitelink|mw.wikibase.sitelink]] -> mw.wikibase.getSitelink
[[https://www.mediawiki.org/wiki/Extension:Wikibase_Client/Lua#mw.wikibase.description|mw.wikibase.description]] -> mw.wikibase.getDescription

The old names should obviously be turned into aliases to the new names, so that this isn't a breaking change.

Details

	Subject	Repo	Branch	Lines +/-
	Update Lua type checks to new function names	mediawiki/extensions/Wikibase	master	+13 -5
	Lua: Rename old mw.wikibase getters to new naming scheme	mediawiki/extensions/Wikibase	master	+73 -41

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T112073 Lua in Wikibase (tracking)
		Resolved		hoo	T190382 Rename Lua functions in old naming scheme

Event Timeline

hoo triaged this task as Medium priority.Mar 22 2018, 3:03 AM

hoo created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2018, 3:03 AM

Change 422090 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Lua: Rename old mw.wikibase getters to new naming scheme

https://gerrit.wikimedia.org/r/422090

gerritbot added a project: Patch-For-Review.Mar 27 2018, 3:41 AM

hoo added a project: Wikidata-Ministry-Of-Magic.Mar 27 2018, 3:44 AM

hoo moved this task from Tasks to Needs Review on the Wikidata-Ministry-Of-Magic board.

Ladsgroup moved this task from Needs Review to Blocked on the Wikidata-Ministry-Of-Magic board.Mar 27 2018, 11:23 AM

Change 422090 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Lua: Rename old mw.wikibase getters to new naming scheme

https://gerrit.wikimedia.org/r/422090

hoo closed this task as Resolved.Mar 27 2018, 11:56 AM

hoo claimed this task.

hoo moved this task from Blocked to Done on the Wikidata-Ministry-Of-Magic board.

hoo removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 27 2018, 12:00 PM

Change 423352 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Update Lua type checks to new function names

https://gerrit.wikimedia.org/r/423352

gerritbot added a project: Patch-For-Review.Apr 2 2018, 12:08 AM

Change 423352 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update Lua type checks to new function names

https://gerrit.wikimedia.org/r/423352

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)); removed MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Apr 3 2018, 2:00 PM