Maniphest T190441

Deprecate and remove 'userActive', as it's a duplicate of 'userAvatar'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Esanders
	Mar 22 2018, 6:56 PM

Description

With M229 in place, 'userActive' is a duplicate of 'userAvatar'

Deprecate 'userActive'
Replace usage of 'userActive' across products – 0 results here
Remove 'userActive'

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.28.0	mediawiki/core	master	+314 -321
[BREAKING CHANGE] icons: Remove deprecated 'userActive'/'userInactive'	oojs/ui	master	+0 -16
icons: Add 'userAnonymous', and deprecate 'userActive'/'userInactive'	oojs/ui	master	+35 -17

Customize query in gerrit

Related Objects

Mentioned In: T189113: 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive'
Mentioned Here: M229: Refined WikimediaUI icons proposal

Event Timeline

• Esanders created this task.Mar 22 2018, 6:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2018, 6:56 PM

There's no differentiation any more for 'userActive'. See https://phabricator.wikimedia.org/M229/791/

In which we case we should pick one as canonical and alias the other one. Also does userInactive need updating?

• Esanders renamed this task from Icon 'userActive' is wrong to Icon 'userActive' is a duplicate of 'userAvatar'.Mar 23 2018, 1:00 AM

• Esanders reopened this task as Open.

• Esanders removed a project: Regression.

@Esanders 'userInteractive' will be removed and we gonna add a new icon.

matmarex mentioned this in T189113: 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive'.Mar 27 2018, 5:42 PM

Change 422353 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Add 'userAnonymous' and deprecate 'userActive'/'userInactive'

https://gerrit.wikimedia.org/r/422353

gerritbot added a project: Patch-For-Review.Mar 28 2018, 4:28 PM

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Mar 28 2018, 4:51 PM

Change 422353 merged by jenkins-bot:
[oojs/ui@master] icons: Add 'userAnonymous', and deprecate 'userActive'/'userInactive'

https://gerrit.wikimedia.org/r/422353

Volker_E renamed this task from Icon 'userActive' is a duplicate of 'userAvatar' to Deprecate and remove 'userActive', as it's a duplicate of 'userAvatar'.Mar 28 2018, 10:04 PM

Volker_E updated the task description. (Show Details)

Volker_E moved this task from Reviewing to Waiting for breaking release on the OOUI board.Mar 28 2018, 11:53 PM

• Petar.petkovic removed a project: Patch-For-Review.Apr 12 2018, 4:54 PM

Volker_E added a project: UI-Standardization.May 23 2018, 11:29 PM

Change 434825 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [BREAKING CHANGE] icons: Remove deprecated 'userActive'/'userInactive'

https://gerrit.wikimedia.org/r/434825

gerritbot added a project: Patch-For-Review.May 23 2018, 11:33 PM

Jdforrester-WMF moved this task from Waiting for breaking release to OOUI-0.28.0 on the OOUI board.Aug 13 2018, 6:16 PM

Jdforrester-WMF edited projects, added OOUI (OOUI-0.28.0); removed OOUI.

Change 434825 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] icons: Remove deprecated 'userActive'/'userInactive'

https://gerrit.wikimedia.org/r/434825

• Petar.petkovic removed a project: Patch-For-Review.Aug 13 2018, 7:41 PM

Change 452872 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

gerritbot added a project: Patch-For-Review.Aug 15 2018, 12:09 AM

Volker_E closed this task as Resolved.Aug 15 2018, 12:31 AM

Volker_E claimed this task.

Volker_E triaged this task as Low priority.

Volker_E removed a project: Patch-For-Review.

Volker_E updated the task description. (Show Details)

Volker_E removed a subscriber: gerritbot.

Change 452872 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.28.0