Page MenuHomePhabricator
Create Task
Maniphest T190530

Enhanced recent changes don't format external usernames well in contributors summary
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Ladsgroup
Authored By
matej_suchanek
Mar 23 2018, 3:31 PM
Tags
Referenced Files
F16993185: obrazek.png
Apr 15 2018, 4:24 PM
F16992587: Screenshot_20180415_175520.png
Apr 15 2018, 3:56 PM
F16001659: obrazek.png
Mar 23 2018, 3:31 PM
Subscribers
Aklapper
gerritbot
Ladsgroup
Lydia_Pintscher
matej_suchanek

Description

Although T189320 has been fixed, external usernames on the main line still show "wikidata>".

Screenshot of Wikidata changes in recent changes on cswiki:

obrazek.png (362×1 px, 54 KB)

Notice the illogical difference between the contributors summary and the other occurrence.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+2 -1Make RCCacheEntry use the local part of the user name for linking
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Mar 23 2018, 3:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2018, 3:31 PM
Lydia_Pintscher closed this task as Resolved.Apr 15 2018, 3:56 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher added a subscriber: Lydia_Pintscher.

I just tried to reproduce it and it seems ok now:

Screenshot_20180415_175520.png (171×1 px, 60 KB)

Please reopen if I missed something.

matej_suchanek reopened this task as Open.Apr 15 2018, 4:24 PM
matej_suchanek removed Lydia_Pintscher as the assignee of this task.

Search for an IP address within [... (#×)].

obrazek.png (91×1 px, 12 KB)

Lydia_Pintscher added a comment.Apr 15 2018, 4:26 PM

Damn :D Ok. Thanks.
Let's see if @Ladsgroup has an idea.

WMDE-leszek added a project: Wikidata-Ministry-Of-Magic.Apr 24 2018, 1:32 PM
WMDE-leszek set the point value for this task to 3.
gerritbot added a subscriber: gerritbot.Apr 24 2018, 6:54 PM

Change 428712 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Make RCCacheEntry use the local part of the user name for linking

https://gerrit.wikimedia.org/r/428712

gerritbot added a project: Patch-For-Review.Apr 24 2018, 6:54 PM
Ladsgroup claimed this task.Apr 24 2018, 6:55 PM
Ladsgroup moved this task from Tasks to Needs Review on the Wikidata-Ministry-Of-Magic board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptApr 24 2018, 6:55 PM
Ladsgroup moved this task from Needs Review to Blocked on the Wikidata-Ministry-Of-Magic board.May 4 2018, 11:54 AM
WMDE-leszek moved this task from Blocked to In Progress on the Wikidata-Ministry-Of-Magic board.May 14 2018, 10:05 AM
Ladsgroup moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.May 19 2018, 12:09 PM
gerritbot added a comment.May 22 2018, 10:45 PM

Change 428712 merged by jenkins-bot:
[mediawiki/core@master] Make RCCacheEntry use the local part of the user name for linking

https://gerrit.wikimedia.org/r/428712

Ladsgroup moved this task from Needs Review to Test (Product Review) on the Wikidata-Ministry-Of-Magic board.May 22 2018, 10:46 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 22 2018, 11:00 PM
Lydia_Pintscher closed this task as Resolved.May 24 2018, 9:28 AM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Ministry-Of-Magic board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL