Page MenuHomePhabricator

Remove diff index from grammatical feature diff headers
Closed, ResolvedPublic2 Story Points

Description

Problem:
The ID of a grammatical feature is shown in a Lexeme diff. This is confusing and the user should not care about this ID.

Example:


It should only say "Form L1-F1 / grammatical feature", without the "/ 0" or "/ 1" at the end.

BDD
GIVEN I am on a diff page
WHEN a diff of grammatical features on a lexeme is presented
THEN no "grammatical feature" id is shown in the diff "breadcrumb"

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseLexeme : masterDo not show Grammatical Feature Diff Index in Diff

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 26 2018, 10:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jakob_WMDE updated the task description. (Show Details)Mar 27 2018, 10:17 AM
Pablo-WMDE rescinded a token.
Pablo-WMDE awarded a token.
Pablo-WMDE updated the task description. (Show Details)Mar 28 2018, 8:24 AM

Let's remove the numbers from the breadcrumbs.
As for the hardcoding of the /: Yes it should be / like in item diffs. Is it hardcoded there? Do the same as done there.

Lydia_Pintscher triaged this task as Low priority.May 27 2018, 3:59 PM
Pablo-WMDE updated the task description. (Show Details)Jun 12 2018, 12:54 PM
Pablo-WMDE updated the task description. (Show Details)Jun 12 2018, 12:57 PM
Pablo-WMDE set the point value for this task to 2.
Jakob_WMDE renamed this task from Unclear behavior of grammatical feature diff headers to Remove diff index from grammatical feature diff headers.Jun 25 2018, 1:24 PM
Jakob_WMDE updated the task description. (Show Details)

@Jakob_WMDE: "I believe the interesting bit of code for the diff ids is in GrammaticalFeatureDiffVisualizer"

Change 447451 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Do not show Grammatical Feature Diff Index in Diff

https://gerrit.wikimedia.org/r/447451

Change 447451 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Do not show Grammatical Feature Diff Index in Diff

https://gerrit.wikimedia.org/r/447451