Page MenuHomePhabricator

EditFilterMergedContent hook shows summary without comment for new sections
Closed, ResolvedPublic

Description

On AbuseFilter workboard we have a task, T58371, where a user noticed that the edit summary is different from what you would expect if you perform the edit by adding a new section. In fact, while in page history (and user contribs, etc.) the displayed summary is /* New_section_name */ something, AbuseFilter simply receives something as summary, without the comment. The reason is that EditFilterMergedContent hook omits the comment for new sections, and it's probably added after the hook is run. I don't know whether this is intentional and/or fixable, however it would be better to already have the comment inside the summary when the hook is run, to get a result which would be more similar to what users see.

Event Timeline

Change 814003 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] EditPage: Disentangle edit summary and section title

https://gerrit.wikimedia.org/r/814003

Change 814003 merged by jenkins-bot:

[mediawiki/core@master] EditPage: Disentangle edit summary and section title

https://gerrit.wikimedia.org/r/814003