See user report, which has a full list of steps.
We are pretty sure this is a mangling caused by DiscussionTools and ConfirmEdit not playing nice together.
See user report, which has a full list of steps.
We are pretty sure this is a mangling caused by DiscussionTools and ConfirmEdit not playing nice together.
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
EditPage: Disentangle edit summary and section title | mediawiki/core | master | +91 -132 |
This seems to occur w/o dt
Steps:
What happens:
The input in the subject box ($1 from step 3 above) is changed:
FROM: $1
TO: /* $1 */ new section
What should have happened:
The input in the subject box ($1 from step 3 above) should be retained.
I can reproduce the same problem with other extensions preventing you from saving edits.
For example, with TemplateData: in step 4, enter <templatedata>{</templatedata> in the body instead, which will show an error message "Syntax error in JSON." instead of saving the page. The subject will be similarly corrupted.
Looks like a core issue to me.
I had a look and the code in EditPage is very confused about whether it's dealing with an edit summary or a section title. For example, I also just found out than when using section=new while not creating a new page, the AbuseFilter summary variable will only contain the subject, rather than the generated summary (looks like it has been reported before: T191722).
I'm sure it's possible to fix this, but it's impossible to predict what else is going to be affected.
As it happens, DiscussionTools new topic tool does not have this bug (honestly, I'm a little offended that you thought that it's the cause ;) ), because it bypasses most of the broken code, so I'm not too inclined to put a lot of effort into this, given that most users already aren't (or soon won't be) using the affected interface.
Agree this is fairly low priority and this use case will decline; but it could be a bug that sticks its head up in other places unexpectedly.
When prioritizing this, please note that not all users will eventually use DiscussionTools—and not only senior contributors deliberately opting out of it won’t, but also for example users who can’t or don’t want to execute JavaScript (old browser, NoScript, organizational security settings etc.). They can well be junior contributors and thus affected by the CAPTCHA.
Change 814003 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/core@master] EditPage: Disentangle edit summary and section title
I wrote a patch, because that's my idea for a fun weekday night. Now you just need to find someone whose idea for a fun weekday night is to review that.
Change 814003 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Disentangle edit summary and section title