Maniphest T192314

[BUG] Batch editing view shows on the left for RTL languages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• NHarateh_WMF
	Apr 16 2018, 8:10 PM

Description

How many times were you able to reproduce it?

5/5

Steps to reproduce

Set device language to Hebrew
Save a few articles
Go to the Saved tab
Tap ''Edit"

Expected results

Batch editing view shows on the right

Actual results

Batch editing view shows on the left

Simulator Screen Shot - iPhone X - 2018-04-16 at 16.09.24.png (2×1 px, 683 KB)

Screenshots

Environments observed

App version: 1388
OS versions: 11.2
Device model: iPhone X
Device language: Hebrew

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Mhurd	T191862 Audit new reading list bits for RTL
		Resolved		• NHarateh_WMF	T192314 [BUG] Batch editing view shows on the left for RTL languages

Event Timeline

• NHarateh_WMF triaged this task as Medium priority.Apr 16 2018, 8:10 PM

• NHarateh_WMF created this task.

• NHarateh_WMF mentioned this in rAPIOSb1e1fc51e5ea: Merge branch 'bug/T192178' into bug/T192314.Apr 16 2018, 9:45 PM

• NHarateh_WMF moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 16 2018, 9:46 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Apr 17 2018, 5:37 PM

• NHarateh_WMF mentioned this in rAPIOSa4075630dcd2: Merge branch 'develop' into bug/T192314.Apr 17 2018, 6:28 PM

• NHarateh_WMF mentioned this in rAPIOS06e01fdd477d: Merge branch 'develop' into bug/T192314.Apr 17 2018, 6:57 PM

• NHarateh_WMF mentioned this in rAPIOSbebc8e67eee0: Merge branch 'bug/T192314' of https://github.com/wikimedia/wikipedia-ios into….

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 17 2018, 7:39 PM

• NHarateh_WMF mentioned this in rAPIOS20552ddf69ca: Merge branch 'develop' into bug/T192314.Apr 17 2018, 8:00 PM

Diffusion mentioned this in rAPIOSa76c9339d0f2: Merge branch 'develop' into bug/T192314.Apr 17 2018, 8:06 PM

Diffusion mentioned this in rAPIOS0b8e9e18bc9c: Merge pull request #2222 from wikimedia/bug/T192314.Apr 17 2018, 8:44 PM

• NHarateh_WMF moved this task from Waiting for Build to Needs QA on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 17 2018, 9:51 PM

Looks good now on 3.8.0 (1390) except on iPad where it is slightly offscreen. Wasn't sure if we want this tracked separately.

• NHarateh_WMF moved this task from Needs QA to Doing on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 18 2018, 5:00 PM

see T192400

• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 18 2018, 9:17 PM

• NHarateh_WMF mentioned this in rAPIOS84212c41b0e2: Merge branch 'develop' into followup/T192314-2.Apr 18 2018, 11:53 PM

Restricted Application added a project: Product-Analytics. · View Herald TranscriptApr 18 2018, 11:53 PM

• Phabricator_maintenance removed a project: Product-Analytics.Apr 19 2018, 12:21 AM

• NHarateh_WMF mentioned this in rAPIOS41777a28f46c: Merge branch 'develop' into followup/T192314-2.Apr 19 2018, 12:25 AM

Diffusion mentioned this in rAPIOS814eb81da8eb: Merge pull request #2234 from wikimedia/followup/T192314-2.Apr 19 2018, 1:18 AM

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 19 2018, 1:49 AM

• NHarateh_WMF moved this task from Waiting for Build to Needs QA on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 19 2018, 11:37 AM

Now works on 5.8.0 (1391) on iPad and iPhone

• JMinor closed this task as Resolved.Apr 19 2018, 11:17 PM

	F17014605: Simulator Screen Shot - iPhone X - 2018-04-16 at 16.09.24.png
	Apr 16 2018, 8:10 PM

	F17063726: IMG_0042.PNG
	Apr 18 2018, 1:03 AM

[BUG] Batch editing view shows on the left for RTL languagesClosed, ResolvedPublicActions