Page MenuHomePhabricator

Allow for non-German IBANs
Closed, ResolvedPublic3 Estimated Story Points

Description

As a donor/membership applicant,
I want to be able to provide my non-German IBAN,
so that I am not required to have a German bank account.

Acceptance Criteria:

  • All IBANs that pass the validation are accepted when donating/becoming a member.

Background:
There actually never was a restriction to German bank accounts. The validation passes for non-German IBANs and the form can be submitted (i. e. the submit button is clickable). But the server responds by showing the form again instead of showing the confirmation page. When donating, an error message is being displayed below the bank data fields. The membership application form leaves users clueless about what's wrong with their input.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen set the point value for this task to 3.Apr 25 2018, 1:22 PM

@kai.nissen For foreign IBAN the BIC still is not a required field, right? Only the IBAN is required?

The fix is in https://github.com/wmde/fundraising-payments/pull/8

I've also improved the E2E tests in https://github.com/wmde/FundraisingFrontend/pull/1223 . They will fail until the payment repo PR is merged.

gabriel-wmde moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-05-02 board.
gabriel-wmde subscribed.

I've added additional BIC validation to the bank data validation. As the BIC is autogenerated this should not lead to errors in most cases.

While the bug is fixed, one test in the donation repo is now failing (because it's testing too much). Work is done in https://github.com/wmde/fundraising-donations/pull/53

Also, FundraisingFrontend should now trim the bank data from the HTTP request, just to be sure.

gabriel-wmde moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-05-02 board.
Vvjjkkii renamed this task from Allow for non-German IBANs to eceaaaaaaa.Jul 1 2018, 1:14 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed the point value for this task.
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 3 2018, 1:40 AM