Maniphest T193005

EntityHandler::getTitleForId should handle FormIDs
Closed, ResolvedPublic
Actions

Description

Background: when adding entity data to ParserOutput, there is a fatal error when the form is used in the statement on the property (see: T192766)

'content-handler-factory-callback' for forms generates LexemeHandler instance which should probably be replaced by some more specialized implementation that can handle FormIDs in getTitleForId method.

Details

	Subject	Repo	Branch	Lines +/-
	Test that forms can be added as data values in statements on properties	mediawiki/extensions/WikibaseLexeme	master	+29 -2
	Use TypeDispatchingEntityTitleStoreLookup instead of EntityContentFactory	mediawiki/extensions/Wikibase	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T192766 Statements with data type "form" cannot be saved on top-level entities
		Resolved		Jakob_WMDE	T193005 EntityHandler::getTitleForId should handle FormIDs

Event Timeline

WMDE-leszek triaged this task as High priority.Apr 25 2018, 11:01 AM

WMDE-leszek created this task.

WMDE-leszek updated the task description. (Show Details)Apr 25 2018, 11:22 AM

Jakob_WMDE claimed this task.Apr 25 2018, 12:00 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Turtles-Sprint#4 board.

Change 429157 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] EntityHandler::getTitleForId should handle FormIds

https://gerrit.wikimedia.org/r/429157

gerritbot added a project: Patch-For-Review.Apr 26 2018, 9:50 AM

Jakob_WMDE mentioned this in rEWLE97a35a5a91a7: EntityHandler::getTitleForId should handle FormIds.Apr 26 2018, 9:53 AM

Jakob_WMDE mentioned this in rEWLE5be45939d115: EntityHandler::getTitleForId should handle FormIds.Apr 26 2018, 10:07 AM

Change 429399 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Use TypeDispatchingEntityTitleStoreLookup instead of EntityContentFactory

https://gerrit.wikimedia.org/r/429399

Jakob_WMDE mentioned this in rEWLE895bd5ac9249: EntityHandler::getTitleForId should handle FormIds.Apr 27 2018, 11:10 AM

Jakob_WMDE mentioned this in rEWLE5911fd734f5b: Test that forms can be added as data values in statements on properties.Apr 27 2018, 11:14 AM

Jakob_WMDE mentioned this in rEWLE25e84ab65f82: Test that forms can be added as data values in statements on properties.Apr 27 2018, 11:25 AM

Jakob_WMDE mentioned this in rEWLE5d5648877b8e: Test that forms can be added as data values in statements on properties.Apr 27 2018, 11:39 AM

For the record, the proposed patch does not make EntityHandler::getTitleForId handle forms, but instead ensures that the custom TitleLookup for forms is used instead

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Turtles-Sprint#4 board.Apr 27 2018, 12:10 PM

Change 429399 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use TypeDispatchingEntityTitleStoreLookup instead of EntityContentFactory

https://gerrit.wikimedia.org/r/429399

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 27 2018, 1:00 PM

Change 429157 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Test that forms can be added as data values in statements on properties

https://gerrit.wikimedia.org/r/429157

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Turtles-Sprint#4 board.Apr 30 2018, 4:08 PM

Jakob_WMDE closed this task as Resolved.May 2 2018, 8:52 AM

• Vvjjkkii renamed this task from EntityHandler::getTitleForId should handle FormIDs to 29daaaaaaa.Jul 1 2018, 1:13 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Jakob_WMDE as the assignee of this task.