Page MenuHomePhabricator
Create Task
Maniphest T193007

Only store numeric property IDs in SqlEntityInfoBuilder
Closed, ResolvedPublic
Actions

Description

Background: when adding entity data to ParserOutput, there is a fatal error when the form is used in the statement on the property (see: T192766)

I.e. numericIdsByType member field would become something like numericPropertyIds and by simple map not two-dimensional one.

Details

SubjectRepoBranchLines +/-
Store only numeric property IDs in SqlEntityInfoBuildermediawiki/extensions/Wikibasemaster+17 -22
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek triaged this task as High priority.Apr 25 2018, 11:19 AM
WMDE-leszek created this task.
WMDE-leszek updated the task description. (Show Details)Apr 25 2018, 11:21 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Turtles-Sprint#4 board.Apr 26 2018, 9:29 AM
gerritbot subscribed.Apr 26 2018, 11:10 AM

Change 429166 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Store only numeric property IDs in SqlEntityInfoBuilder

https://gerrit.wikimedia.org/r/429166

gerritbot added a project: Patch-For-Review.Apr 26 2018, 11:10 AM
gerritbot added a comment.Apr 27 2018, 11:13 AM

Change 429166 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Store only numeric property IDs in SqlEntityInfoBuilder

https://gerrit.wikimedia.org/r/429166

Jakob_WMDE closed this task as Resolved.Apr 27 2018, 11:17 AM
Jakob_WMDE claimed this task.
Jakob_WMDE moved this task from Doing to Done on the Wikidata-Turtles-Sprint#4 board.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 27 2018, 12:00 PM
• Vvjjkkii renamed this task from Only store numeric property IDs in SqlEntityInfoBuilder to 09daaaaaaa.Jul 1 2018, 1:14 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Jakob_WMDE as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Mainframe98 renamed this task from 09daaaaaaa to Only store numeric property IDs in SqlEntityInfoBuilder.Jul 1 2018, 8:03 AM
Mainframe98 closed this task as Resolved.
Mainframe98 assigned this task to Jakob_WMDE.
Mainframe98 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Mainframe98 updated the task description. (Show Details)
Mainframe98 added subscribers: Aklapper, gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits