Since tagging of actions which hit the condition limit is enabled, I've only seen it hit by mass actions, specifically MassMessage delivery and Nuke. I'm not sure about why this happens, but I don't think we should keep this going. I imagine it may be because those actions perform "all actions at once", so for instance AF may count all those actions as a single one (so conditions get summed up and of course break the conds limit). Anyway, we should probably find a way to avoid this behaviour, since it only clogs logs of condition limit reached.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Reset condCount when entering checkAllFilters | mediawiki/extensions/AbuseFilter | master | +3 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Daimona | T193374 Mass actions always reach condition limit | |||
| Open | None | T193375 Use the problems' dedicated page instead of tags to show actions which hit the condition limit |
Event Timeline
Comment Actions
I imagine it may be because those actions perform "all actions at once", so for instance AF may count all those actions as a single one (so conditions get summed up and of course break the conds limit).
This should be it, yeah.
Anyway, we should probably find a way to avoid this behaviour, since it only clogs logs of condition limit reached.
By ensuring the initial number conditions is always zero maybe?
Comment Actions
Change 429838 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Reset condCount when entering checkAllFilters
Comment Actions
Change 429838 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Reset condCount when entering checkAllFilters
Comment Actions
The problem itself is solved, nor I see other new problems due to the fix. In fact, on enwiki (where the tag was applied 21000 times), the last entry is on May 31st, which is the day the wmf.6 version came on group 2. Same on itwiki, and MediaWiki message delivery delivered lots of messages in between, so everything is fine.