Page MenuHomePhabricator

Investigation: Advanced search not working on huwiki
Closed, ResolvedPublic3 Estimated Story Points

Description

Advanced search does not work on huwiki for unknown reasons.

Using the advances parameters on hu.wikipedia.org one always gets no results. The advanced search parameters are not mapped to searchkeywords in the search-URL-Argument.

Example Search-URL after serching for pages with template Kiemelt:
https://hu.wikipedia.org/w/index.php?search=&title=Speci%C3%A1lis%3AKeres%C3%A9s&profile=advanced&fulltext=1&advancedSearch-current=%7B%22options%22%3A%7B%22hastemplate%22%3A%5B%22Kiemelt%22%5D%7D%2C%22namespaces%22%3A%5B%220%22%5D%7D&ns0=1

Decoded and formated:

https://hu.wikipedia.org/w/index.php
?search=
&title=Speciális:Keresés
&profile=advanced
&fulltext=1
&advancedSearch-current={"options":{"hastemplate":["Kiemelt"]},"namespaces":["0"]}
&ns0=1

Bildschirmfoto zu 2018-05-09 16-00-35.png (467×1 px, 50 KB)

Acceptance Criteria

  • If the reason is advancedsearch, fix it
  • If the reason is hu-wiki common.js, leave at least a comment on the problem and a way to fix it, and ping bencemac about it

Notes

  • We should see if there are any search specific special cases for hu-wiki, e.g. default gadgets and stuff.
  • We should check if the css classes stay the same, or if we could accidentally be hiding the search results
  • These situations did not occur on de-, alemannisch, bavarian, en-, commons wiki

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

WMDE-FUN-Team if you have room to pull something from AdvancedSearch into the sprint, this might be a good candidate :)

Lea_WMDE renamed this task from Advanced search not working on huwiki to Investigation: Advanced search not working on huwiki.May 14 2018, 9:36 AM
Lea_WMDE triaged this task as High priority.
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE set the point value for this task to 3.

The JS-Console shows an error:

VM48:4 Uncaught ReferenceError: $this is not defined
    at HTMLFormElement.SubSearch (<anonymous>:4:717)
    at HTMLFormElement.dispatch (VM43 load.php:69)
    at HTMLFormElement.elemData.handle (VM43 load.php:66)
SubSearch @ VM48:4
dispatch @ VM43 load.php:69
elemData.handle @ VM43 load.php:66
SubSearch	@	VM48:4
dispatch	@	VM43 load.php:69
elemData.handle	@	VM43 load.php:66

This is a local customization problem on huwp: ReferenceError: $this is not defined points to the line 202 $input = $( '#' + $this.data( 'fixSearch-inputId' ) ); in https://hu.wikipedia.org/w/index.php?title=MediaWiki:Common.js&oldid=19491899

Search without advancedSearch still works on hu-wiki

CC'ing some people who have edited MediaWiki:Common.js on huwiki in the past. See T194274#4204314 for the problem.

Vvjjkkii renamed this task from Investigation: Advanced search not working on huwiki to tadaaaaaaa.Jul 1 2018, 1:10 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Tacsipacsi as the assignee of this task.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed the point value for this task.
Vvjjkkii removed a subscriber: Aklapper.
Tacsipacsi renamed this task from tadaaaaaaa to Investigation: Advanced search not working on huwiki.Jul 1 2018, 9:52 AM
Tacsipacsi closed this task as Resolved.
Tacsipacsi claimed this task.
Tacsipacsi updated the task description. (Show Details)
Tacsipacsi set the point value for this task to 3.
Tacsipacsi added a subscriber: Aklapper.