Page MenuHomePhabricator

'View all data' (revision browser) page for commons
Closed, ResolvedPublic

Description

My feeling is that we'd need to separate out the data view by projects (wikipedias, wikisources, commons, Wikiversity etc.) because trying to put everything in one view will make it more confusing than convenient for the user since the different datasets will have different headers. And splitting it out makes it possible to tailor the download buttons to the project so we don't end up giving the user one gigantic csv or one huge wikitable with everything crammed in it.
I'm trying to also think about how abstract-able this would be so we can build it more easily. Though nothing is straightforward with this tool. :)
Here's a mock that I thought might work:

image.png (910×1 px, 224 KB)

I have a few questions, mainly for @MusikAnimal -

  1. What do you think? Other ideas?
  2. If the tab idea seems good, do you think we can fetch all data at once so the tab switching can be seamless? We're okay with it taking long (~2 minutes) to generate that data.

Good? Bad? Ugly? Let's brainstorm!

Event Timeline

Yeah I was thinking at some point we'd want some sorting and filtering options. The tabs look cool! Maybe eventually we'd want a dropdown given there are some 11+ different wiki families. I also envision a "sort by" dropdown, with options like username and wiki.

Right now for Commons, I'm showing the corresponding revision that goes with each uploaded file, giving you the same column headings. What other kinds of data would we show that doesn't involve a revision?

If the tab idea seems good, do you think we can fetch all data at once so the tab switching can be seamless?

Yes I think so. We can experiment to see how slow it will go but shouldn't be too bad.

Though nothing is straightforward with this tool. :)

I agree!!

"Page" heading doesn't go well with Commons. It can be renamed to "Page/File" to temporarily mitigate that.
Good idea about the filtering options. It seems more like a nice-to-have. For now though we should build the tabs to let them see just the commons edits.
I don't think this will expand to 11+ wiki families ever. 4 or 5 at maximum.

For the download buttons - we can either have them tie to the tab selected (give them the csv for wikipedias when they are on that tab and so on) or have them give the user all data in one go. Probably the latter (easier to build).

I'd like to get @Shouston_WMF's opinion on this ticket too.

The page title for files is "File:Foo bar.jpg", with the namespace prefix, if that helps. In this case it is technically still a page (the revision, that is). Only file pages that are new are listed, so copyedits to the description etc. won't show up. A true "upload" indeed is a different log. So maybe if they change the view to show Commons-only, we could make the "Page" heading instead be "File", and even have a thumbnail column, along with the number of articles it's being used in, etc., whatever we want! I suggest only in the combined view that show "File:Foo bar.jpg" listed under "Page" (likewise "Draft:Foo" when we support those).

The download options run the same queries as the revision browser (only the latter is truncated at 100 rows), so if we add filtering options they could just as easily apply to the downloads. I think this would be a useful feature.

Other filtering options may involve some work, but simple sorting is a matter of appending GROUP BY and/or ORDER BY to the query. I agree it's still a nice-to-have. The only one I see as especially useful is sorting by wiki, but in that case you'd probably want a filter (show ONLY enwiki revisions, not all Wikipedia revisions grouped by wiki). Anyway, save all of that for later discussion!

@MusikAnimal Okay. I think for now, we should keep what we have. I played around with it on the staging instance and it looks good. You're right that at some point we would need a wider array of filters and the tabs won't be sufficient. Let's save filtering options for another ticket when we work on it. I'll remember to refer to ideas we brought up in this ticket then.

So I guess this ticket is done for free along with the frontend one? :)

There was a tiny bit of work that went into showing the "File:" prefix for file pages, but otherwise yes, this one and the frontend (current design) was for free :) But I'd definitely love to add filtering/sorting at some point. Especially when you have a LOT of revisions, the current download options may not even work (at least the wikitext). One of those good kinds of problems!

Niharika claimed this task.
Niharika moved this task from Backlog to Done on the Grant-Metrics board.

Okay, we'll discuss about filtering at some point. I created T194696: Filtering options for view all data page so we don't forget about it.

Vvjjkkii renamed this task from 'View all data' (revision browser) page for commons to 09caaaaaaa.Jul 1 2018, 1:11 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Niharika as the assignee of this task.
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 09caaaaaaa to 'View all data' (revision browser) page for commons.Jul 1 2018, 2:45 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Niharika.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.