Page MenuHomePhabricator

OOUI Checkboxes missing the checkmark in Safari since v0.27.0
Closed, ResolvedPublic

Description

Since last week, when I click on a box like "this is a minor edit" one, in both 2010 and 2017 wikitext editor, Safari 11.1, I don't get any checkmarks. The box turns blue, but no checkmark appears.
FWIW it also happens if I try to enable a Beta feature I still don't have from the Prefs tab, and on multiple wikis, like mw.org and office wiki.

image.png (382×984 px, 43 KB)

Event Timeline

Jdforrester-WMF renamed this task from Checkboxes missing the checkmark to OOUI Checkboxes missing the checkmark in Safari since v0.27.0.May 15 2018, 11:36 AM

Not sure this is Safari? This isn't happening anymore on mw.org for me, but it still happens on Office wiki.

For future reference: we had issues with Safari not rendering the checkmarks in the past, but we worked around them: T89309: [Regression wmf17] Safari - cannot click in any check-box. Somehow the recent changes must have triggered a similar issue again (rGOJUec032ef96417: CheckboxInputWidget: Don't specify icon in CSS).

Same issue (https://bugs.webkit.org/show_bug.cgi?id=141789) seems to creep on us here again, yes! Safari 11.1 strikes on OOUI checkboxes in demo.

Change 435935 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Fix regression on Safari bug

https://gerrit.wikimedia.org/r/435935

Change 435935 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Fix regression on Safari bug

https://gerrit.wikimedia.org/r/435935

Volker_E claimed this task.
Volker_E moved this task from Reviewing to OOUI-0.27.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.27.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Vvjjkkii renamed this task from OOUI Checkboxes missing the checkmark in Safari since v0.27.0 to wzcaaaaaaa.Jul 1 2018, 1:11 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Volker_E as the assignee of this task.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Niharika renamed this task from wzcaaaaaaa to OOUI Checkboxes missing the checkmark in Safari since v0.27.0 .Jul 1 2018, 5:01 AM
Niharika closed this task as Resolved.
Niharika assigned this task to Volker_E.
Niharika lowered the priority of this task from High to Medium.
Niharika updated the task description. (Show Details)
Niharika added a subscriber: Aklapper.