Maniphest T194839

VisualEditor crashes on a particular template insertion
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	matej_suchanek
	May 16 2018, 4:28 PM

Description

Steps to reproduce:

Go to an arbitrary page on Czech Wikipedia.
Open visual editor.
"Insert" > "Template" > Input "Poznámka pod čarou" > "Add template"
Fill the suggested parameter with arbitrary text.
Click "Insert".

Instead of inserting the template, the editor gets stuck.

The content of the template is {{#tag:ref|{{{1}}}|group="P"}}.

Browser console reports:

jQuery.Deferred exception: element.querySelectorAll is not a function ve.stripParsoidFallbackIds@https://cs.wikipedia.org/w/load.php?...:1803:856
ve.ce.MWTransclusionNode.static.filterRendering@https://cs.wikipedia.org/w/load.php?...:2149:859
ve.dm.MWTransclusionModel.prototype.insertTransclusionNode/<@https://cs.wikipedia.org/w/load.php?...:2155:196
mightThrow@https://cs.wikipedia.org/w/load.php?debug=false&lang=cs&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0upuj5q:49:590
resolve/</process<@https://cs.wikipedia.org/w/load.php?debug=false&lang=cs&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0upuj5q:50:269
 undefined

Details

	Subject	Repo	Branch	Lines +/-
	Fix ve.ce.MWTransclusionNode#filterRendering to work with non-element nodes	mediawiki/extensions/VisualEditor	master	+8 -4

Customize query in gerrit

Related Objects

Mentioned In: T193582: Getting error "Uncaught TypeError: element.querySelectorAll is not a function" while loading an article in cx2 to translate

Event Timeline

matej_suchanek created this task.May 16 2018, 4:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2018, 4:28 PM

• Esanders claimed this task.May 16 2018, 5:50 PM

• Esanders triaged this task as High priority.

• Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

• Esanders updated the task description. (Show Details)

Change 433430 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix ve.ce.MWTransclusionNode#filterRendering to work with non-element nodes

https://gerrit.wikimedia.org/r/433430

gerritbot added a project: Patch-For-Review.May 17 2018, 6:19 PM

Change 433430 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix ve.ce.MWTransclusionNode#filterRendering to work with non-element nodes

https://gerrit.wikimedia.org/r/433430

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 18 2018, 1:02 PM

• Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.May 19 2018, 9:30 AM

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.May 19 2018, 5:40 PM

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Templates; removed Patch-For-Review.

Jdforrester-WMF set the point value for this task to 1.

• Deskana closed this task as Resolved.May 28 2018, 3:40 PM

Arrbee mentioned this in T193582: Getting error "Uncaught TypeError: element.querySelectorAll is not a function" while loading an article in cx2 to translate.Jun 6 2018, 3:21 PM

• Vvjjkkii renamed this task from VisualEditor crashes on a particular template insertion to 4ucaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed • Esanders as the assignee of this task.