Page MenuHomePhabricator
Create Task
Maniphest T195325

Page media endpoint missing math formula images
Closed, ResolvedPublic
Actions

Description

https://en.wikipedia.org/api/rest_v1/page/media/tangent

is missing the images for the formulas embedded in the article, for example:

https://wikimedia.org/api/rest_v1/media/math/render/svg/3c924ec6626c572300b256a28bbb285cc98fe040

On iOS, we cached those images when the user saves the article, so that the full article with formulas is available offline. It'd be ideal if they were added to the items list, and items were given a property to indicate whether or not the image should be included in the fullscreen image gallery (these images would have that property set to false)

Details

SubjectRepoBranchLines +/-
Media: Always return showInGallery propertymediawiki/services/mobileappsmaster+2 -2
Media: Add Mathoid math formula image supportmediawiki/services/mobileappsmaster+39 -12
Customize query in gerrit

Related Objects

Event Timeline

JoeWalsh created this task.May 22 2018, 7:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2018, 7:29 PM
• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.EditedMay 23 2018, 10:33 PM
• Mholloway subscribed.

Yeah, I sort of just punted on Mathoid images for v1, but since there's a specific product need now it's probably time to get it done.

• Mholloway renamed this task from Page media missing some images to Page media missing math images.May 30 2018, 2:41 PM
• Mholloway renamed this task from Page media missing math images to Page media endpoint missing math formula images.
• Mholloway claimed this task.
• Mholloway moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
gerritbot subscribed.May 30 2018, 8:07 PM

Change 436360 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Media: Add Mathoid math formula image support

https://gerrit.wikimedia.org/r/436360

gerritbot added a project: Patch-For-Review.May 30 2018, 8:07 PM
• Mholloway moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.May 30 2018, 8:07 PM
gerritbot added a comment.May 31 2018, 3:01 PM

Change 436360 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Media: Add Mathoid math formula image support

https://gerrit.wikimedia.org/r/436360

• Mholloway moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.May 31 2018, 3:04 PM
• Mholloway added a comment.May 31 2018, 3:09 PM

Hey @JoeWalsh, the above patch is live on appservice.wmflabs.org:

http://appservice.wmflabs.org/en.wikipedia.org/v1/page/media/Tangent

Does that look more or less as expected?

• Mholloway closed this task as Resolved.Jun 4 2018, 8:49 PM
• Mholloway moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

This is live:

https://en.wikipedia.org/api/rest_v1/page/media/Tangent

Please reopen if any changes are needed.

JoeWalsh added a comment.Jun 4 2018, 9:04 PM
This comment was removed by JoeWalsh.
• Mholloway added a comment.Jun 5 2018, 2:10 PM

@JoeWalsh I see you removed your comment but if I understood it correctly I thought it was a good one. Not sure I quite caught your point about web clients but it's true that having a flag that can only be false is pretty crappy for weakly typed clients. Maybe the boolean flag should be present for all entries?

• Vvjjkkii renamed this task from Page media endpoint missing math formula images to mhcaaaaaaa.Jul 1 2018, 1:09 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed • Mholloway as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from mhcaaaaaaa to Page media endpoint missing math formula images.Jul 2 2018, 3:57 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to • Mholloway.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
JoeWalsh added a comment.Jul 2 2018, 6:38 PM

@Mholloway thanks to the phabricator spam I came across this ticket again. I'm fine either way, I initially thought it was a bug but I hadn't implemented it properly. This sort of thing is something we should standardize across the APIs, and maybe always populating a boolean field makes the most sense.

gerritbot added a comment.Jul 9 2018, 9:31 PM

Change 444744 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Media: Always return showInGallery property

https://gerrit.wikimedia.org/r/444744

gerritbot added a comment.Jul 10 2018, 3:28 PM

Change 444744 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Media: Always return showInGallery property

https://gerrit.wikimedia.org/r/444744

Stashbot subscribed.Jul 11 2018, 8:16 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-11T20:16:33Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@03fa731]: Update mobileapps to b5e152d (T195325 T189830 T177619 T196523)

Stashbot mentioned this in T189830: Improve media endpoint performance.Jul 11 2018, 8:16 PM
Stashbot mentioned this in T177619: Return variant URLs and titles in the metadata response.
Stashbot mentioned this in T196523: Page Preview should not strip space before period.
Stashbot added a comment.Jul 11 2018, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-11T20:20:04Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@03fa731]: Update mobileapps to b5e152d (T195325 T189830 T177619 T196523) (duration: 03m 30s)

Stashbot added a comment.Jul 11 2018, 10:18 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-11T22:18:16Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@03fa731]: Update mobileapps to b5e152d (T195325 T189830 T177619 T196523)

Stashbot added a comment.Jul 11 2018, 10:25 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-11T22:25:00Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@03fa731]: Update mobileapps to b5e152d (T195325 T189830 T177619 T196523) (duration: 06m 44s)

JoeWalsh mentioned this in T202311: Add attributes to "Picture of the day".Aug 21 2018, 6:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL