Page MenuHomePhabricator
Create Task
Maniphest T196161

Add support for unencoded Unicode URLs
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

URLs in encoded form can be used for import:
https://ar.wikipedia.org/wiki/%D9%85%D9%84%D9%81:1967%2BTUN.jpg
https://ar.wikipedia.org/wiki/%D9%85%D9%84%D9%81:UD_%D9%84%D9%88%D8%BA%D8%B1%D9%8A%D9%86%D9%8A%D9%8A%D8%B3.png

Unencoded URLs can't:
https://ar.wikipedia.org/wiki/ملف:1967+TUN.jpg
https://ar.wikipedia.org/wiki/File:UD لوغرينييس.png

Failed to discover API location from: "https://ar.wikipedia.org/wiki/File:UD لوغرينييس.png". Status code 200,

Technically this is a missing feature, but from the users perspective (these users are used to unencoded URLs working) it's a bug.

Acceptance criteria:

Details

SubjectRepoBranchLines +/-
Normalize spaces in Wikimedia source URLsmediawiki/extensions/FileImportermaster+21 -9
Allow plus characters in source URLsmediawiki/extensions/FileImportermaster+25 -8
Provide non-empty plain text message in HttpRequestExceptionmediawiki/extensions/FileImportermaster+7 -1
Fix incomplete error reporting in HttpApiLookupmediawiki/extensions/FileImportermaster+21 -13
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Jun 1 2018, 1:57 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJun 1 2018, 1:57 PM
thiemowmde triaged this task as Medium priority.Jun 1 2018, 1:57 PM
thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.
WMDE-Fisch added a comment.Jun 1 2018, 2:15 PM

Sounds a bit like what I got with curl and where I added this patch

https://gerrit.wikimedia.org/r/#/c/436224/

If you look at the code around there you also will know why that comma. We should look at it when we schedule the ticket.

Bmueller moved this task from Backlog to Tickets ready for pickup on the Move-Files-To-Commons board.Jun 4 2018, 12:10 PM
thiemowmde mentioned this in rEFLIc82bda071b2a: Extract normalization of mobile URLs to separate class.Jun 5 2018, 10:02 AM
thiemowmde mentioned this in rEFLIc0cb22f92dbe: Extract normalization of mobile URLs to separate class.
thiemowmde added a comment.Jun 5 2018, 10:37 AM

@Bmueller, can you add what you know about the original bug report as provided by the user? I'm looking for the filename. Does it contain spaces or underscores? If it does, then this is not about Unicode support, but about spaces.

gerritbot subscribed.Jun 5 2018, 10:39 AM

Change 437435 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Normalize spaces in Wikimedia source URLs

https://gerrit.wikimedia.org/r/437435

gerritbot added a project: Patch-For-Review.Jun 5 2018, 10:39 AM
thiemowmde mentioned this in rEFLI554f425852fe: Normalize spaces in Wikimedia source URLs.Jun 5 2018, 10:40 AM
thiemowmde mentioned this in rEFLIc4210acf2368: Normalize spaces in Wikimedia source URLs.Jun 5 2018, 10:57 AM
Tobi_WMDE_SW set the point value for this task to 3.Jun 5 2018, 12:38 PM
Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2018-06-05.
Tobi_WMDE_SW subscribed.

Include fixing of error handling.

Tobi_WMDE_SW moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.Jun 5 2018, 12:56 PM
gerritbot added a comment.Jun 5 2018, 2:50 PM

Change 437478 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Fix incomplete error reporting in HttpApiLookup

https://gerrit.wikimedia.org/r/437478

thiemowmde mentioned this in rEFLI0266689adf07: Fix incomplete error reporting in HttpApiLookup.Jun 5 2018, 2:53 PM
thiemowmde mentioned this in rEFLI7b5ea176f744: Fix incomplete error reporting in HttpApiLookup.Jun 5 2018, 4:10 PM
gerritbot added a comment.Jun 5 2018, 4:37 PM

Change 437506 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Provide non-empty plain text message in HttpRequestException

https://gerrit.wikimedia.org/r/437506

thiemowmde mentioned this in rEFLI3dee2a9acb6e: Provide non-empty plain text message in HttpRequestException.Jun 5 2018, 4:38 PM
gerritbot added a comment.Jun 6 2018, 8:12 AM

Change 437478 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fix incomplete error reporting in HttpApiLookup

https://gerrit.wikimedia.org/r/437478

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 6 2018, 9:00 AM
thiemowmde claimed this task.Jun 6 2018, 9:32 AM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-06-05 board.
Bmueller added a comment.EditedJun 6 2018, 9:32 AM

@thiemowmde, this is the originial bug report: "When I click EditFileInfo or Info button, I get an error 200."

Screenshot:

Bugreport screenshot.png (425×1 px, 55 KB)

gerritbot added a comment.Jun 6 2018, 11:17 AM

Change 437729 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Allow plus characters in source URLs

https://gerrit.wikimedia.org/r/437729

thiemowmde mentioned this in rEFLI5a5b04caedbc: Allow plus characters in source URLs.Jun 6 2018, 11:17 AM
thiemowmde mentioned this in rEFLI12e106eea6f3: Allow plus characters in source URLs.Jun 6 2018, 11:50 AM
thiemowmde mentioned this in rEFLIf0a24965d8aa: Provide non-empty plain text message in HttpRequestException.Jun 6 2018, 11:52 AM
gerritbot added a comment.Jun 6 2018, 12:33 PM

Change 437506 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Provide non-empty plain text message in HttpRequestException

https://gerrit.wikimedia.org/r/437506

gerritbot added a comment.Jun 6 2018, 12:47 PM

Change 437729 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Allow plus characters in source URLs

https://gerrit.wikimedia.org/r/437729

thiemowmde updated the task description. (Show Details)Jun 6 2018, 4:29 PM
gerritbot added a comment.Jun 7 2018, 1:19 PM

Change 437435 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Normalize spaces in Wikimedia source URLs

https://gerrit.wikimedia.org/r/437435

WMDE-Fisch updated the task description. (Show Details)Jun 7 2018, 1:32 PM
WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-06-05 board.
thiemowmde mentioned this in rEFLI8485e140a4f8: Final NoteDb migration updates.Jun 9 2018, 1:35 AM
WMDE-Fisch added a comment.Jun 11 2018, 12:13 PM

Can be tested with

https://test.wikimedia.beta.wmflabs.org/wiki/Special:ImportFile?clientUrl=https://ar.wikipedia.org/wiki/File:UD لوغرينييس.png

( or any other file url you put behind the clientUrl= )

• Vvjjkkii renamed this task from Add support for unencoded Unicode URLs to eubaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii removed thiemowmde as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed a subscriber: gerritbot.
CommunityTechBot renamed this task from eubaaaaaaa to Add support for unencoded Unicode URLs.Jul 2 2018, 1:45 PM
CommunityTechBot assigned this task to thiemowmde.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot set the point value for this task to 3.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: gerritbot.
• Lea_WMDE closed this task as Resolved.Jul 3 2018, 12:19 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:58 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 3:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits