Page MenuHomePhabricator

EventBus should produce messages to Kafka with event time set to meta.dt
Closed, ResolvedPublic5 Estimated Story Points

Description

Now that main Kafka clusters are on Kafka 1.x, we can take advantage of Kafka's timestamp indexes. We should produce the Kafka message with the timestamp set to the event's meta.dt field.

Event Timeline

Ottomata triaged this task as Medium priority.Jun 4 2018, 9:05 PM
Ottomata created this task.

Change 437479 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[eventlogging@master] Produce kafka-python messages with timestamp set to Event time

https://gerrit.wikimedia.org/r/437479

Ah, we need to change a Kafka broker setting to support this too. log.message.timestamp.type should be set to CreateTime, rather than LogAppendTime. Need to understand what happens to records that don't have event timestamps set if we are using CreateTime.

See also: https://cwiki.apache.org/confluence/display/KAFKA/KIP-32+-+Add+timestamps+to+Kafka+message

Change 437614 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[operations/puppet@production] Kafka - Change default message.timestamp.type to CreateTime

https://gerrit.wikimedia.org/r/437614

Change 437614 merged by Ottomata:
[operations/puppet@production] Kafka - Change default message.timestamp.type to CreateTime

https://gerrit.wikimedia.org/r/437614

Mentioned in SAL (#wikimedia-operations) [2018-06-07T14:55:59Z] <ottomata> beginning rolling restarts of all cluster kafka brokers to apply log.message.timestamp.type=CreateTime - T196407

Change 437479 merged by Ottomata:
[eventlogging@master] Produce kafka-python messages with timestamp set to Event time

https://gerrit.wikimedia.org/r/437479

Mentioned in SAL (#wikimedia-operations) [2018-06-11T13:52:55Z] <otto@deploy1001> Started deploy [eventlogging/eventbus@08a1dff]: Producing events with kafka timestamp set to event time - T196407

Mentioned in SAL (#wikimedia-operations) [2018-06-11T13:54:50Z] <otto@deploy1001> Finished deploy [eventlogging/eventbus@08a1dff]: Producing events with kafka timestamp set to event time - T196407 (duration: 01m 55s)

Mentioned in SAL (#wikimedia-operations) [2018-06-11T13:56:24Z] <otto@deploy1001> Started deploy [eventlogging/analytics@08a1dff]: Producing events with kafka timestamp set to event time - T196407

Mentioned in SAL (#wikimedia-operations) [2018-06-11T13:56:28Z] <otto@deploy1001> Finished deploy [eventlogging/analytics@08a1dff]: Producing events with kafka timestamp set to event time - T196407 (duration: 00m 04s)

Vvjjkkii renamed this task from EventBus should produce messages to Kafka with event time set to meta.dt to knbaaaaaaa.Jul 1 2018, 1:05 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Ottomata as the assignee of this task.
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed the point value for this task.
Vvjjkkii removed subscribers: Aklapper, gerritbot.
CommunityTechBot renamed this task from knbaaaaaaa to EventBus should produce messages to Kafka with event time set to meta.dt.Jul 2 2018, 7:11 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Ottomata.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot set the point value for this task to 5.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: Aklapper, gerritbot.