Page MenuHomePhabricator
Create Task
Maniphest T197122

Update the block notices on mobile web to be page specific
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem
Mobile web editor's block notices are not page specific.

Solution
Once an API exists to check for a page-specific block (See T194585) Mobile web editor (for logged in and IP users) should be updated to use this API to determine if the current user is blocked from editing the page.

Details

SubjectRepoBranchLines +/-
Update the block notices to be page specific.mediawiki/extensions/MobileFrontendmaster+108 -62
Customize query in gerrit

Related Objects
Search...

Event Timeline

dbarratt created this task.Jun 13 2018, 3:09 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptJun 13 2018, 3:09 PM
dbarratt added a subtask: T194585: Expose whether a user is blocked from editing a specific page via the API.Jun 13 2018, 3:09 PM
dbarratt renamed this task from Fix Mobile web block notices to be page specific to Update Mobile web block notices to be page specific.Jun 13 2018, 3:34 PM
Jdlrobson added a project: Web-Team-Backlog (Tracking).Jun 13 2018, 3:54 PM
Jdlrobson moved this task from Backlog to TODO on the MinervaNeue board.Jun 13 2018, 3:57 PM
• TBolliger moved this task from Untriaged to Product/Tech backlog on the Anti-Harassment board.Jun 13 2018, 4:43 PM
• Vvjjkkii renamed this task from Update Mobile web block notices to be page specific to p3aaaaaaaa.Jul 1 2018, 1:04 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
Scott renamed this task from p3aaaaaaaa to Update Mobile web block notices to be page specific.Jul 1 2018, 4:57 PM
Scott lowered the priority of this task from High to Medium.
Scott removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Scott updated the task description. (Show Details)
Scott added a subscriber: Aklapper.
dbarratt added a subscriber: matmarex.Jul 10 2018, 4:20 AM
dbarratt mentioned this in T199917: RFC: Block users by page, namespace, and/or action (Partial Blocks).Jul 19 2018, 9:04 AM
• TBolliger moved this task from Product/Tech backlog to Triage/To be Estimated on the Anti-Harassment board.Aug 30 2018, 7:12 PM
dbarratt renamed this task from Update Mobile web block notices to be page specific to Update mobile web block notices to be page specific.Sep 7 2018, 6:12 PM
• TBolliger renamed this task from Update mobile web block notices to be page specific to Update mobile web (Minerva) block notices to be page specific.Sep 7 2018, 6:12 PM
• TBolliger renamed this task from Update mobile web (Minerva) block notices to be page specific to Update the block notices on mobile web to be page specific.
• TBolliger set the point value for this task to 5.Sep 7 2018, 6:22 PM
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
dbarratt closed subtask T194585: Expose whether a user is blocked from editing a specific page via the API as Invalid.Sep 24 2018, 8:53 PM
dbarratt updated the task description. (Show Details)Sep 24 2018, 8:55 PM
dbarratt updated the task description. (Show Details)
dbarratt updated the task description. (Show Details)Sep 24 2018, 9:04 PM
dbarratt reopened subtask T194585: Expose whether a user is blocked from editing a specific page via the API as Open.Sep 24 2018, 9:06 PM
matmarex unsubscribed.Sep 25 2018, 5:59 AM
• aezell moved this task from Cards ready for development to AHT Sprint 30 on the Anti-Harassment board.Sep 26 2018, 7:09 PM
• aezell edited projects, added Anti-Harassment (AHT Sprint 30); removed Anti-Harassment.
dbarratt claimed this task.Oct 9 2018, 8:51 PM
dbarratt moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 30) board.
dbarratt added a subscriber: • TBolliger.

@TBolliger What would you like this to be updated to?

• TBolliger added a comment.Oct 9 2018, 9:11 PM

I just dummied this up for a slide deck. :)

test.m.wikipedia.org_w_index.php_title=Freedom_of_speech&mobileaction=toggle_view_mobile(iPhone 6_7_8).png (1×750 px, 141 KB)

Your account has been blocked from editing this page

dbarratt removed dbarratt as the assignee of this task.Oct 9 2018, 9:27 PM
dbarratt moved this task from In progress to Ready on the Anti-Harassment (AHT Sprint 30) board.
• TBolliger moved this task from AHT Sprint 30 to AHT Sprint 31 on the Anti-Harassment board.Oct 12 2018, 7:19 PM
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 31); removed Anti-Harassment (AHT Sprint 30).
dbarratt added a subscriber: Jdlrobson.Oct 15 2018, 5:19 PM
dbarratt claimed this task.Oct 16 2018, 4:39 PM
dbarratt moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 31) board.
dbarratt closed subtask T194585: Expose whether a user is blocked from editing a specific page via the API as Resolved.Oct 16 2018, 7:55 PM
gerritbot subscribed.Oct 17 2018, 4:04 PM

Change 468013 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/MobileFrontend@master] Update the block notices to be page specific.

https://gerrit.wikimedia.org/r/468013

gerritbot added a project: Patch-For-Review.Oct 17 2018, 4:04 PM
dbarratt moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 31) board.Oct 17 2018, 4:04 PM
dbarratt moved this task from Review to In progress on the Anti-Harassment (AHT Sprint 31) board.Oct 17 2018, 5:26 PM
Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog (Tracking).Oct 17 2018, 5:49 PM

Pulling into sprint for visibility.

Jdlrobson moved this task from To Do to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 17 2018, 5:49 PM
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 5:22 PM
dbarratt moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 31) board.Oct 19 2018, 2:55 AM
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 22 2018, 9:17 PM
• TBolliger moved this task from AHT Sprint 31 to AHT Sprint 32 on the Anti-Harassment board.Oct 24 2018, 7:10 PM
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 32); removed Anti-Harassment (AHT Sprint 31).
• TBolliger moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 32) board.
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 24 2018, 10:11 PM
dbarratt moved this task from Review to In progress on the Anti-Harassment (AHT Sprint 32) board.Oct 29 2018, 1:54 PM
dbarratt moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 32) board.Oct 29 2018, 1:59 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2).Nov 1 2018, 12:02 AM

Ping me if you need any follow up help from reading web. I think you can take this patch from here!

gerritbot added a comment.Nov 2 2018, 9:03 PM

Change 468013 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update the block notices to be page specific.

https://gerrit.wikimedia.org/r/468013

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 2 2018, 10:00 PM
dbarratt closed this task as Resolved.Nov 5 2018, 2:31 PM
dbarratt moved this task from Review to Done on the Anti-Harassment (AHT Sprint 32) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits