Page MenuHomePhabricator
Create Task
Maniphest T197584

InvalidArgumentException for betacluster eswiki
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

On accessing https://es.wikipedia.beta.wmflabs.org/wiki/Especial:CambiosRecientes results:

[WyeTpwpEEj4AAASfyH0AAAAC] /wiki/Especial:CambiosRecientes InvalidArgumentException from line 58 of /srv/mediawiki/php-master/extensions/ORES/includes/Storage/SqlModelLookup.php: No model available for [goodfaith]

Backtrace:

#0 /srv/mediawiki/php-master/extensions/ORES/includes/Storage/PopulatedSqlModelLookup.php(106): ORES\Storage\SqlModelLookup->getModelVersion(string)
#1 /srv/mediawiki/php-master/extensions/ORES/includes/ThresholdLookup.php(108): ORES\Storage\PopulatedSqlModelLookup->getModelVersion(string)
#2 /srv/mediawiki/php-master/extensions/ORES/includes/ThresholdLookup.php(99): ORES\ThresholdLookup->fetchThresholdsFromCache(string)
#3 /srv/mediawiki/php-master/extensions/ORES/includes/ThresholdLookup.php(84): ORES\ThresholdLookup->fetchThresholds(string, boolean)
#4 /srv/mediawiki/php-master/extensions/ORES/includes/ThresholdLookup.php(90): ORES\ThresholdLookup->getRawThresholdData(string, boolean)
#5 /srv/mediawiki/php-master/extensions/ORES/includes/Hooks/ChangesListHooksHandler.php(186): ORES\ThresholdLookup->getThresholds(string)
#6 /srv/mediawiki/php-master/includes/Hooks.php(174): ORES\Hooks\ChangesListHooksHandler::onChangesListSpecialPageStructuredFilters(SpecialRecentChanges)
#7 /srv/mediawiki/php-master/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#8 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(979): Hooks::run(string, array)
#9 /srv/mediawiki/php-master/includes/specials/SpecialRecentchanges.php(184): ChangesListSpecialPage->registerFilters()
#10 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(1120): SpecialRecentChanges->registerFilters()
#11 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(939): ChangesListSpecialPage->setup(NULL)
#12 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(708): ChangesListSpecialPage->getOptions()
#13 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(623): ChangesListSpecialPage->considerActionsForDefaultSavedQuery(NULL)
#14 /srv/mediawiki/php-master/includes/specials/SpecialRecentchanges.php(166): ChangesListSpecialPage->execute(NULL)
#15 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(565): SpecialRecentChanges->execute(NULL)
#16 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(569): SpecialPage->run(NULL)
#17 /srv/mediawiki/php-master/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#18 /srv/mediawiki/php-master/includes/MediaWiki.php(867): MediaWiki->performRequest()
#19 /srv/mediawiki/php-master/includes/MediaWiki.php(524): MediaWiki->main()
#20 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#21 /srv/mediawiki/w/index.php(3): include(string)
#22 {main}

Related Objects

Event Timeline

MarcoAurelio created this task.Jun 18 2018, 11:15 AM
Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptJun 18 2018, 11:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
awight merged a task: T197586: ORES is breaking beta eswiki Special:RecentChanges.Jun 18 2018, 11:32 AM
awight subscribed.
MarcoAurelio added a comment.Jun 18 2018, 11:35 AM

I made https://es.wikipedia.beta.wmflabs.org/?diff=33280 and the page now seems to work.

Ladsgroup subscribed.Jun 19 2018, 7:35 AM

Yes, After only one edit, the system finds the new models and update the database, it shouldn't be like that but also we need to write to the database and writes should not happen in GET requests (due to support for multi-dc scalability)

awight closed this task as Resolved.Jun 19 2018, 7:41 AM
awight claimed this task.

@Ladsgroup This is certainly a corner case, but I'm thinking we should still catch the exception and silently disable ORES features rather than crash the page...

Ladsgroup added a comment.Jun 19 2018, 7:45 AM

I agree with that and we should have some sort of phabricator ticket to track that. If there's such thing, let me know and I pick it up.

awight mentioned this in T197647: Gracefully handle edge case where wiki is not receiving edits.Jun 19 2018, 8:02 AM
MarcoAurelio added a comment.Jun 19 2018, 10:41 AM

Thanks for your assistance :-)

• Vvjjkkii renamed this task from InvalidArgumentException for betacluster eswiki to vqaaaaaaaa.Jul 1 2018, 1:03 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed awight as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: Aklapper, MarcoAurelio.
CommunityTechBot renamed this task from vqaaaaaaaa to InvalidArgumentException for betacluster eswiki.Jul 2 2018, 4:41 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to awight.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: Aklapper, MarcoAurelio.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
isarantopoulos moved this task from Unsorted to 2023-2024 Q3 Done on the Machine-Learning-Team board.Nov 20 2023, 12:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits