Page MenuHomePhabricator
Create Task
Maniphest T197805

All fundraising python scripts should run on python 3 by 2020
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Python 2.7 is end of life on Jan 1, 2020. By then all of the following should be solidly running on python 3 or be rewritten in another language:

  • Audit downloaders
  • PayPal audit parser (rewrite as SmashPig module?)
  • Silverpop export

Details

SubjectRepoBranchLines +/-
SafeConfigParser -> ConfigParserwikimedia/fundraising/toolsmaster+12 -12
Convert fr tools to python 3wikimedia/fundraising/toolsmaster+146 -197
Rename queue module to prepare for python 2->3 conversionwikimedia/fundraising/toolsmaster+16 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ejegg created this task.Jun 20 2018, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2018, 3:08 PM
• Vvjjkkii renamed this task from All fundraising python scripts should run on python 3 by 2020 to qkaaaaaaaa.Jul 1 2018, 1:02 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from qkaaaaaaaa to All fundraising python scripts should run on python 3 by 2020.Jul 2 2018, 8:50 AM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Jul 2 2018, 7:38 PM
• DStrine moved this task from Sprint +1 to Q3 2021-2022 on the Fundraising-Backlog board.
• DStrine moved this task from Q3 2021-2022 to FY 2022-2023 on the Fundraising-Backlog board.May 6 2019, 9:35 PM
gerritbot added a comment.Jul 3 2019, 1:38 AM

Change 520350 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/tools@master] WIP python3 conversion

https://gerrit.wikimedia.org/r/520350

gerritbot added a project: Patch-For-Review.Jul 3 2019, 1:38 AM
gerritbot added a comment.Jul 3 2019, 2:41 PM

Change 520457 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/tools@master] Rename queue module to prepare for python 2->3 conversion

https://gerrit.wikimedia.org/r/520457

gerritbot added a comment.Jul 4 2019, 3:39 AM

Change 520669 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/tools@master] SafeConfigParser -> ConfigParser

https://gerrit.wikimedia.org/r/520669

Ejegg claimed this task.Jul 4 2019, 3:40 AM
Ejegg triaged this task as Medium priority.
Ejegg moved this task from FY 2022-2023 to Current Sprint on the Fundraising-Backlog board.
Ejegg added a project: Fundraising Sprint Men In Slack.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Men In Slack board.
Ejegg set the point value for this task to 2.
Ejegg added a comment.Jul 4 2019, 3:43 AM

Turned out not to be so bad with the 2to3 utility. Not everything has been tested yet! Silverpop export and paypal audit parsers do seem to work.
Need to at least test audit downloaders. There's a lot of stuff in there that we haven't used in the last couple of years.

Ejegg added a comment.Jul 5 2019, 7:23 PM

Tested the audit downloader, and it seems to work too.

• DStrine added a project: Fundraising Sprint Never Ending Query.Jul 9 2019, 8:37 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Never Ending Query board.Jul 10 2019, 3:30 PM
gerritbot added a comment.Jul 16 2019, 3:08 PM

Change 520457 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] Rename queue module to prepare for python 2->3 conversion

https://gerrit.wikimedia.org/r/520457

jgleeson subscribed.Jul 16 2019, 6:06 PM

Could you add some tips on how to test functionality of some of the core utilities affected please?

Ejegg added a comment.Jul 17 2019, 3:54 PM

Oops, I just realized I haven't smoke-tested the sending to queue parts. I'll try that today!

• DStrine added a project: Fundraising Sprint Office  .Jul 23 2019, 8:30 PM
Xqt subscribed.Jul 24 2019, 8:37 AM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Office   board.Jul 24 2019, 3:47 PM
• DStrine added a project: Fundraising Sprint Princess Mongodb.Aug 6 2019, 9:09 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Princess Mongodb board.Aug 8 2019, 4:40 PM
Ejegg closed subtask T213757: Replace MySQL-python with pymysql in fundraising python scripts as Resolved.Aug 15 2019, 8:50 PM
• DStrine added a project: Fundraising Sprint Quick and the Deadlocked.Aug 20 2019, 8:44 PM
Eileenmcnaughton moved this task from Backlog to Review on the Fundraising Sprint Quick and the Deadlocked board.Aug 20 2019, 11:45 PM
Eileenmcnaughton moved this task from Review to Doing on the Fundraising Sprint Quick and the Deadlocked board.
Ejegg moved this task from Doing to Review on the Fundraising Sprint Quick and the Deadlocked board.Aug 21 2019, 10:56 PM
gerritbot added a comment.Aug 29 2019, 5:49 PM

Change 520350 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] Convert fr tools to python 3

https://gerrit.wikimedia.org/r/520350

gerritbot added a comment.Aug 29 2019, 5:49 PM

Change 520669 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] SafeConfigParser -> ConfigParser

https://gerrit.wikimedia.org/r/520669

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Men In Slack board.Aug 29 2019, 5:59 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 29 2019, 6:11 PM
Ejegg mentioned this in rMWVAfde2e1c516e8: Use pip3 to install fundraising tools. Bug: T197805.Aug 29 2019, 7:31 PM
Ejegg moved this task from Review to Deployed on the Fundraising Sprint Quick and the Deadlocked board.Aug 29 2019, 10:09 PM
• DStrine added a project: Fundraising Sprint Rocky Horror Presentation Layer.Sep 3 2019, 8:24 PM
Ejegg moved this task from Backlog to Deployed on the Fundraising Sprint Rocky Horror Presentation Layer board.Sep 3 2019, 10:26 PM
Ejegg closed this task as Resolved.Sep 4 2019, 12:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits