Maniphest T197853

Trailing single quote in DOIs breaks citoid
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Mvolz
	Jun 21 2018, 10:20 AM

Description

https://en.wikipedia.org/api/rest_v1/data/citation/mediawiki/10.1017%2Fs0305004100013554'

gives

{

"type": "https://mediawiki.org/wiki/HyperSwitch/errors/not_found",
"title": "Not found.",
"method": "get",
"uri": "/en.wikipedia.org/v1/data/citation/mediawiki/10.1017%2Fs0305004100013554'"

}

instead of the expected error

{ Error: Unable to resolve DOI }

and

http://DOI.org/10.1007/11926078_68'

gives

[

{
  "url": "http://DOI.org/10.1007/11926078_68'",
  "itemType": "journalArticle",
  "DOI": "10.1007/11926078_68%27"
}

]

instead of the expected 404.

0.1642/0004-8038(2005)122[0673:PROAGP]2.0.CO;2

Also causes hyperswitch error instead of an expected error

Details

	Subject	Repo	Branch	Lines +/-
	Make crossref method fail	mediawiki/services/citoid	master	+36 -4

Customize query in gerrit

Related Objects

Mentioned In: T165105: Some requests for DOIs are failing or very slow; if we have a DOI and the request is taking too long, just use CrossRef data instead.
Mentioned Here: rGCITfd77117b3e81: Force early return for some DOIs
T165105: Some requests for DOIs are failing or very slow; if we have a DOI and the request is taking too long, just use CrossRef data instead.

Event Timeline

Mvolz created this task.Jun 21 2018, 10:20 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 21 2018, 10:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Mvolz updated the task description. (Show Details)Jun 21 2018, 10:21 AM

Mvolz renamed this task from Unexpected hyperswitch error in production in citoid from bad input to Trailing single quote in DOIs breaks citoid.Jun 21 2018, 10:32 AM

Mvolz claimed this task.

Mvolz triaged this task as High priority.

Mvolz updated the task description. (Show Details)

Mvolz updated the task description. (Show Details)Jun 21 2018, 10:35 AM

Change 441383 had a related patch set uploaded (by Mvolz; owner: Mvolz):
[mediawiki/services/citoid@master] Make crossref method fail

https://gerrit.wikimedia.org/r/441383

gerritbot added a project: Patch-For-Review.Jun 21 2018, 12:20 PM

Mvolz added a project: Regression.Jun 21 2018, 12:26 PM

• mobrovac moved this task from Backlog to Waiting on Deploy on the Citoid board.Jun 21 2018, 1:02 PM

Change 441383 merged by jenkins-bot:
[mediawiki/services/citoid@master] Make crossref method fail

https://gerrit.wikimedia.org/r/441383

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Jun 25 2018, 4:23 PM

Mvolz removed a project: Patch-For-Review.Jun 28 2018, 11:24 AM

Mentioned in SAL (#wikimedia-operations) [2018-06-29T10:18:06Z] <mobrovac@deploy1001> Started deploy [citoid/deploy@40cdff7]: Update citoid to fd77117 - T165105 T197853

Mentioned in SAL (#wikimedia-operations) [2018-06-29T10:21:32Z] <mobrovac@deploy1001> Finished deploy [citoid/deploy@40cdff7]: Update citoid to fd77117 - T165105 T197853 (duration: 03m 26s)

• Vvjjkkii renamed this task from Trailing single quote in DOIs breaks citoid to ejaaaaaaaa.Jul 1 2018, 1:02 AM

• Vvjjkkii removed Mvolz as the assignee of this task.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

Mvolz renamed this task from ejaaaaaaaa to Trailing single quote in DOIs breaks citoid.Jul 1 2018, 8:50 AM

Mvolz lowered the priority of this task from High to Medium.

Mvolz removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser, Regression.

Mvolz updated the task description. (Show Details)

Mvolz removed a subscriber: Stashbot.

In T197853#4305076, @gerritbot wrote:

Change 441383 had a related patch set uploaded (by Mvolz; owner: Mvolz):
[mediawiki/services/citoid@master] Make crossref method fail

https://gerrit.wikimedia.org/r/441383

This patched solved this issue:

and

http://DOI.org/10.1007/11926078_68'

gives

[

{
  "url": "http://DOI.org/10.1007/11926078_68'",
  "itemType": "journalArticle",
  "DOI": "10.1007/11926078_68%27"
}

]

But not the underlying issue. That now returns a hyperswitch error as well. The underlying issue is that ' is not url encoded, and citoid is fine with treating this as a valid string, but hyperswitch seems to have a problem with it?

' usually gets encoded into %27. As the first part of the search string is url-encoded, might this be a copy/paste mistake or something similar?

Mvolz moved this task from Waiting on Deploy to Production on the Citoid board.Jul 2 2018, 12:14 PM

CommunityTechBot assigned this task to Mvolz.Jul 3 2018, 2:27 PM

CommunityTechBot updated the task description. (Show Details)

• Deskana removed a project: VisualEditor.Aug 21 2018, 1:04 PM

• mobrovac added a project: Platform Team Legacy (Watching / External).Dec 20 2018, 12:03 PM

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Trailing single quote in DOIs breaks citoidOpen, MediumPublicActions

Description

Details

Related Objects

Event Timeline

Trailing single quote in DOIs breaks citoid
Open, MediumPublic
Actions