Maniphest T197967

Comment::vote: Expected mass commit of all peer transactions (DBO_TRX set).
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Paladox
	Jun 22 2018, 3:49 PM

Description

Hi, i am seeing this in the logs:

Wikimedia\Rdbms\DBUnexpectedError from line 3769 of /srv/mediawiki/w/includes/libs/rdbms/database/Database.php: Comment::vote: Expected mass commit of all peer transactions (DBO_TRX set).
#0 /srv/mediawiki/w/extensions/Comments/includes/Comment.class.php(428): Wikimedia\Rdbms\Database->commit(string)
#1 /srv/mediawiki/w/extensions/Comments/includes/api/CommentVote.api.php(19): Comment->vote(string)
#2 /srv/mediawiki/w/includes/api/ApiMain.php(1579): CommentVoteAPI->execute()
#3 /srv/mediawiki/w/includes/api/ApiMain.php(535): ApiMain->executeAction()
#4 /srv/mediawiki/w/includes/api/ApiMain.php(506): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/w/api.php(94): ApiMain->execute()
#6 {main}

I am using mediawiki 1.31 and php 7.2

Details

	Subject	Repo	Branch	Lines +/-
	Remove or convert commit calls to atomic sections where appropriate	mediawiki/extensions/Comments	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned In: T247807: Can't post comments, 1.31.5 LTS

Event Timeline

Paladox created this task.Jun 22 2018, 3:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2018, 3:49 PM

Paladox renamed this task from Wikimedia\Rdbms\DBUnexpectedError from line 3769 of /srv/mediawiki/w/includes/libs/rdbms/database/Database.php: Comment::vote: Expected mass commit of all peer transactions (DBO_TRX set). to Comment::vote: Expected mass commit of all peer transactions (DBO_TRX set)..Jun 24 2018, 12:56 PM

Paladox edited projects, added MediaWiki-extensions-Comments; removed MediaWiki-extensions-Other.

Paladox added subscribers: SamanthaNguyen, ashley.

Restricted Application added a project: Social-Tools. · View Herald TranscriptJun 24 2018, 12:56 PM

Change 441628 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/Comments@master] Convert commit calls to atomic sections

https://gerrit.wikimedia.org/r/441628

gerritbot added a project: Patch-For-Review.Jun 24 2018, 1:27 PM

SamanthaNguyen unsubscribed.Jun 24 2018, 3:46 PM

Change 441628 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Remove or convert commit calls to atomic sections where appropriate

https://gerrit.wikimedia.org/r/441628

ashley closed this task as Resolved.Jun 27 2018, 4:57 PM

ashley claimed this task.

ashley removed a project: Patch-For-Review.

• Vvjjkkii renamed this task from Comment::vote: Expected mass commit of all peer transactions (DBO_TRX set). to 8faaaaaaaa.Jul 1 2018, 1:02 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed ashley as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from 8faaaaaaaa to Comment::vote: Expected mass commit of all peer transactions (DBO_TRX set)..Jul 2 2018, 10:43 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to ashley.

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)