Page MenuHomePhabricator

TMH video player frontend fails to initialize on Parsoid HTML format (mwembed)
Closed, ResolvedPublic

Description

On page content rendered from Parsoid, the new-style figure HTML wrapper for videos doesn't get handled correctly in player frontend initialization. Ends up with invisible player and no functionality.

Broken out from T198103: this was found on the preview mode for the new VE-integrated wikitext editor.

Most likely the current code is expecting size attributes that are not present.

Event Timeline

brion created this task.Jun 26 2018, 10:03 PM

Change 442365 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fixes for parsoid-rendered previews in NWE / 2017 wikitext editor

https://gerrit.wikimedia.org/r/442365

Merged the above patch, but I think you need to fix videos-in-galleries too.

Change 442742 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix for videos in galleries in NWE preview

https://gerrit.wikimedia.org/r/442742

Change 442365 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fixes for parsoid-rendered previews in NWE / 2017 wikitext editor

https://gerrit.wikimedia.org/r/442365

Change 442742 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix for videos in galleries in NWE preview

https://gerrit.wikimedia.org/r/442742