This only occurs when highlighting is enabled in the query parameters on page load. If you load a page like wiki/Special:Watchlist?limit=500&days=30&enhanced=1&watchlistactivity__unseen_color=c1&watchlistactivity__seen_color=c2&urlversion=2, you'll see that FilterTagMultiselectWidget calls the parent onChangeTags method, and then we end up at updateIfHeightChanged where a resize event occurs.
It doesn't seem like we need to call the parent onChangeTags while the app is still initializing.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T197168 Fix slow Watchlist load and interaction times | |||
| Resolved | kostajh | T198399 Avoid unnecessary calls to updateIfHeightChanged on page load when highlighting is in query params |
Change 442862 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] RC Filters: Check if app is initialized before calling change tags
Change 442862 merged by jenkins-bot:
[mediawiki/core@master] RC Filters: Check if app is initialized before calling change tags
Change 442997 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/core@wmf/1.32.0-wmf.10] RC Filters: Check if app is initialized before calling change tags
Change 442997 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] RC Filters: Check if app is initialized before calling change tags
Mentioned in SAL (#wikimedia-operations) [2018-06-28T23:54:06Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.10/resources/src/mediawiki.rcfilters/: Watchlist perf fixes (T198359, T198399) (duration: 00m 52s)
Change 443211 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] RC Filters: Prevent updateIfHeightChanged on tag multiselect widget
Change 443211 merged by jenkins-bot:
[mediawiki/core@master] RC Filters: Prevent updateIfHeightChanged on tag multiselect widget
Change 443517 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/core@wmf/1.32.0-wmf.10] RC Filters: Prevent updateIfHeightChanged on tag multiselect widget
Change 443517 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] RC Filters: Prevent updateIfHeightChanged on tag multiselect widget
Mentioned in SAL (#wikimedia-operations) [2018-07-02T23:33:04Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.10/resources/src/: Watchlist performance fixes (T198359, T198399) (duration: 00m 51s)