Page MenuHomePhabricator
Create Task
Maniphest T198359

Reduce number of times we apply highlights
Closed, ResolvedPublic
Actions

Description

We're currently calling applyHighlights() and clearHighlights() a bunch of times (~12) while this.controller.initializing is true. There's a conditional check for this.filtersModelInitialized but that is true when this.controller.initializing is true also. The patch (coming) reduces the calls to apply/clear to two times on page load.

Details

SubjectRepoBranchLines +/-
RC Filters: Avoid unnecessary update events when clearing highlightmediawiki/corewmf/1.32.0-wmf.10+4 -0
RC Filters: Avoid unnecessary update events when clearing highlightmediawiki/coremaster+4 -0
RC Filters: Don't apply/clear highlighting while still initializingmediawiki/corewmf/1.32.0-wmf.10+14 -23
RC Filters: Don't apply/clear highlighting while still initializingmediawiki/coremaster+14 -23
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT197168 Fix slow Watchlist load and interaction times
 ResolvedkostajhT198359 Reduce number of times we apply highlights

Event Timeline

kostajh triaged this task as Medium priority.Jun 27 2018, 8:56 PM
kostajh created this task.
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 27 2018, 8:56 PM
gerritbot added a comment.Jun 27 2018, 9:01 PM

Change 442739 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] RC Filters: Don't apply/clear highlighting while still initializing

https://gerrit.wikimedia.org/r/442739

gerritbot added a project: Patch-For-Review.Jun 27 2018, 9:01 PM
IKhitron unsubscribed.Jun 27 2018, 9:22 PM
gerritbot added a comment.Jun 27 2018, 11:09 PM

Change 442739 merged by jenkins-bot:
[mediawiki/core@master] RC Filters: Don't apply/clear highlighting while still initializing

https://gerrit.wikimedia.org/r/442739

gerritbot added a comment.Jun 28 2018, 12:23 AM

Change 442752 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/core@wmf/1.32.0-wmf.10] RC Filters: Don't apply/clear highlighting while still initializing

https://gerrit.wikimedia.org/r/442752

gerritbot added a comment.Jun 28 2018, 11:28 PM

Change 442752 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] RC Filters: Don't apply/clear highlighting while still initializing

https://gerrit.wikimedia.org/r/442752

Stashbot subscribed.Jun 28 2018, 11:54 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-28T23:54:06Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.10/resources/src/mediawiki.rcfilters/: Watchlist perf fixes (T198359, T198399) (duration: 00m 52s)

Stashbot mentioned this in T198399: Avoid unnecessary calls to updateIfHeightChanged on page load when highlighting is in query params.Jun 28 2018, 11:54 PM
gerritbot added a comment.Jun 29 2018, 8:44 PM

Change 443138 had a related patch set uploaded (by Kosta Harlan; owner: Kostajh):
[mediawiki/core@master] RC Filters: Avoid unnecessary update events when clearing highlight

https://gerrit.wikimedia.org/r/443138

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 6:01 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 7:01 PM
gerritbot added a comment.Jul 2 2018, 10:36 PM

Change 443138 merged by jenkins-bot:
[mediawiki/core@master] RC Filters: Avoid unnecessary update events when clearing highlight

https://gerrit.wikimedia.org/r/443138

gerritbot added a comment.Jul 2 2018, 10:57 PM

Change 443518 had a related patch set uploaded (by Catrope; owner: Kostajh):
[mediawiki/core@wmf/1.32.0-wmf.10] RC Filters: Avoid unnecessary update events when clearing highlight

https://gerrit.wikimedia.org/r/443518

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jul 2 2018, 11:00 PM
gerritbot added a comment.Jul 2 2018, 11:22 PM

Change 443518 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.10] RC Filters: Avoid unnecessary update events when clearing highlight

https://gerrit.wikimedia.org/r/443518

Stashbot added a comment.Jul 2 2018, 11:33 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-02T23:33:04Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.10/resources/src/: Watchlist performance fixes (T198359, T198399) (duration: 00m 51s)

Catrope closed this task as Resolved.Jul 2 2018, 11:55 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 3 2018, 12:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL